Removing unneeded blocking from tests (#25399)

Author: Drawaes

src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.DefaultProxyCredentials.cs

@@ -46,7 +46,7 @@ public void SetGet_Roundtrips()
         [ActiveIssue(20010, TargetFrameworkMonikers.Uap)]
         [OuterLoop] // TODO: Issue #11345
         [Fact]
-        public void ProxyExplicitlyProvided_DefaultCredentials_Ignored()
+        public async Task ProxyExplicitlyProvided_DefaultCredentials_Ignored()
         {
             int port;
             Task<LoopbackGetRequestHttpProxy.ProxyResult> proxyTask = LoopbackGetRequestHttpProxy.StartAsync(out port, requireAuth: true, expectCreds: true);
@@ -66,7 +66,7 @@ public void ProxyExplicitlyProvided_DefaultCredentials_Ignored()
                 {
                     using (t.Result) return t.Result.Content.ReadAsStringAsync();
                 }, TaskScheduler.Default).Unwrap();
-                Task.WaitAll(proxyTask, responseTask, responseStringTask);
+                await (new Task[] { proxyTask, responseTask, responseStringTask }).WhenAllOrAnyFailed();
 
                 TestHelper.VerifyResponseBody(responseStringTask.Result, responseTask.Result.Content.Headers.ContentMD5, false, null);
                 Assert.Equal(Encoding.ASCII.GetString(proxyTask.Result.ResponseContent), responseStringTask.Result);

src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.cs

@@ -156,7 +156,7 @@ public void Ctor_ExpectedDefaultPropertyValues_NotUapPlatform()
                 Assert.False(handler.PreAuthenticate);
                 Assert.True(handler.SupportsProxy);
                 Assert.True(handler.SupportsRedirectConfiguration);
-                
+
                 // Changes from .NET Framework (Desktop).
                 if (!PlatformDetection.IsFullFramework)
                 {
@@ -329,7 +329,7 @@ public async Task SendAsync_GetWithInvalidHostHeader_ThrowsException()
             }
         }
 
-        [ActiveIssue(22158, TargetFrameworkMonikers.Uap)] 
+        [ActiveIssue(22158, TargetFrameworkMonikers.Uap)]
         [OuterLoop] // TODO: Issue #11345
         [Fact]
         public async Task GetAsync_IPv6LinkLocalAddressUri_Success()
@@ -599,7 +599,7 @@ await LoopbackServer.CreateServerAsync(async (origServer, origUrl) =>
                             "\r\n");
                     await TestHelper.WhenAllCompletedOrAnyFailed(getResponseTask, serverTask);
 
-                    List <string> receivedRequest = await serverTask;
+                    List<string> receivedRequest = await serverTask;
                     string[] statusLineParts = receivedRequest[0].Split(' ');
 
                     using (HttpResponseMessage response = await getResponseTask)
@@ -1392,7 +1392,7 @@ public async Task GetAsync_StatusCodeOutOfRange_ExpectedException(int statusCode
                 // UAP platform allows this status code due to historical reasons.
                 return;
             }
-            
+
             await LoopbackServer.CreateServerAsync(async (server, url) =>
             {
                 using (HttpClient client = CreateHttpClient())
@@ -2158,7 +2158,7 @@ await response.Content.ReadAsStringAsync(),
         [SkipOnTargetFramework(TargetFrameworkMonikers.Uap, "UAP does not support custom proxies.")]
         [OuterLoop] // TODO: Issue #11345
         [Fact]
-        public void Proxy_HaveNoCredsAndUseAuthenticatedCustomProxy_ProxyAuthenticationRequiredStatusCode()
+        public async Task Proxy_HaveNoCredsAndUseAuthenticatedCustomProxy_ProxyAuthenticationRequiredStatusCode()
         {
             int port;
             Task<LoopbackGetRequestHttpProxy.ProxyResult> proxyTask = LoopbackGetRequestHttpProxy.StartAsync(
@@ -2172,7 +2172,7 @@ public void Proxy_HaveNoCredsAndUseAuthenticatedCustomProxy_ProxyAuthenticationR
             using (var client = new HttpClient(handler))
             {
                 Task<HttpResponseMessage> responseTask = client.GetAsync(Configuration.Http.RemoteEchoServer);
-                Task.WaitAll(proxyTask, responseTask);
+                await (new Task[] { proxyTask, responseTask }).WhenAllOrAnyFailed();
                 using (responseTask.Result)
                 {
                     Assert.Equal(HttpStatusCode.ProxyAuthenticationRequired, responseTask.Result.StatusCode);

src/System.Net.Http/tests/FunctionalTests/HttpContentTest.cs

@@ -108,7 +108,7 @@ public async Task CopyToAsync_BufferContentFirst_UseBufferedStreamAsSource()
         {
             var data = new byte[10];
             var content = new MockContent(data);
-            content.LoadIntoBufferAsync().Wait();
+            await content.LoadIntoBufferAsync();
 
             Assert.Equal(1, content.SerializeToStreamAsyncCount);
             var destination = new MemoryStream();