Make it clear that the default proxy cannot by set via environment variable on Windows (#28610)

rmkerr · web-flow · commit 620d01432fd3 · 2018-03-29T15:41:18.000-07:00
* Remove ActiveIssue tag to make it clear this is by design.

* Disable test using attribute.
diff --git a/src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.DefaultProxyCredentials.cs b/src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.DefaultProxyCredentials.cs
@@ -89,10 +89,10 @@ await proxyServer.AcceptConnectionAsync(async connection =>
         }
 
         [OuterLoop] // TODO: Issue #11345
+        [PlatformSpecific(TestPlatforms.AnyUnix)] // The default proxy is resolved via WinINet on Windows.
         [Theory]
         [InlineData(false)]
         [InlineData(true)]
-        [ActiveIssue(25640, TestPlatforms.Windows)] // TODO It should be enabled for SocketsHttpHandler on all platforms
         public async Task ProxySetViaEnvironmentVariable_DefaultProxyCredentialsUsed(bool useProxy)
         {
             const string ExpectedUsername = "rightusername";

Original file line number	Diff line number	Diff line change
`@@ -89,10 +89,10 @@ await proxyServer.AcceptConnectionAsync(async connection =>`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`[OuterLoop] // TODO: Issue #11345`
	`92`	`+ [PlatformSpecific(TestPlatforms.AnyUnix)] // The default proxy is resolved via WinINet on Windows.`
`92`	`93`	`[Theory]`
`93`	`94`	`[InlineData(false)]`
`94`	`95`	`[InlineData(true)]`
`95`		`- [ActiveIssue(25640, TestPlatforms.Windows)] // TODO It should be enabled for SocketsHttpHandler on all platforms`
`96`	`96`	`public async Task ProxySetViaEnvironmentVariable_DefaultProxyCredentialsUsed(bool useProxy)`
`97`	`97`	`{`
`98`	`98`	`const string ExpectedUsername = "rightusername";`