Disabling binary serialization fuzzying test (#21185) (#21189)

danmoseley · ViktorHofer · commit 66c71fb306b8 · 2017-06-18T20:00:48.000+02:00
diff --git a/src/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs b/src/System.Runtime.Serialization.Formatters/tests/BinaryFormatterTests.cs
@@ -363,9 +363,11 @@ public void ObjectReference_RealObjectSerialized()
             Assert.Equal(42, real);
         }
 
-        [OuterLoop]
-        [Theory]
-        [MemberData(nameof(FuzzInputs_MemberData))]
+        // Test is disabled becaues it can cause improbable memory allocations leading to interminable paging.
+        // We're keeping the code because it could be useful to a dev making local changes to binary formatter code.
+        //[OuterLoop]
+        //[Theory]
+        //[MemberData(nameof(FuzzInputs_MemberData))]
         public void Deserialize_FuzzInput(object obj, Random rand)
         {
             // Get the serialized data for the object

Original file line number	Diff line number	Diff line change
`@@ -363,9 +363,11 @@ public void ObjectReference_RealObjectSerialized()`
`363`	`363`	`Assert.Equal(42, real);`
`364`	`364`	`}`
`365`	`365`
`366`		`- [OuterLoop]`
`367`		`- [Theory]`
`368`		`- [MemberData(nameof(FuzzInputs_MemberData))]`
	`366`	`+ // Test is disabled becaues it can cause improbable memory allocations leading to interminable paging.`
	`367`	`+ // We're keeping the code because it could be useful to a dev making local changes to binary formatter code.`
	`368`	`+ //[OuterLoop]`
	`369`	`+ //[Theory]`
	`370`	`+ //[MemberData(nameof(FuzzInputs_MemberData))]`
`369`	`371`	`public void Deserialize_FuzzInput(object obj, Random rand)`
`370`	`372`	`{`
`371`	`373`	`// Get the serialized data for the object`