Fixed autolog tests (#28939)

Author: Anipik

src/System.ServiceProcess.ServiceController/tests/ServiceBaseTests.cs

@@ -164,52 +164,33 @@ public void TestOnContinueBeforePause()
         [ConditionalFact(nameof(IsElevatedAndSupportsEventLogs))]
         public void LogWritten()
         {
-            using (EventLog eventLog = new EventLog("Application"))
-            {
-                ServiceBase sb = new ServiceBase() { ServiceName = nameof(LogWritten) + Guid.NewGuid().ToString() };
-                Assert.False(EventLog.SourceExists(sb.ServiceName));
-                try
-                {
-                    ServiceBase.Run(sb);
-                    eventLog.Source = sb.ServiceName;
-                    Assert.True(EventLog.SourceExists(sb.ServiceName));
-                }
-                finally
-                {
-                    sb.Stop();
-                    EventLog.DeleteEventSource(sb.ServiceName);
-                }
-            }
+            string serviceName = Guid.NewGuid().ToString();
+            // The default username for installing the service is NT AUTHORITY\\LocalService which does not have access to EventLog.
+            // If the username is null, then the service is created under LocalSystem Account which have access to EventLog.
+            var testService = new TestServiceProvider(serviceName, userName: null);
+            Assert.True(EventLog.SourceExists(serviceName));
+            testService.DeleteTestServices();
         }
 
         [ConditionalFact(nameof(IsElevatedAndSupportsEventLogs))]
         public void LogWritten_AutoLog_False()
         {
-            using (EventLog eventLog = new EventLog("Application"))
-            {
-                ServiceBase sb = new ServiceBase() { ServiceName = nameof(LogWritten) + Guid.NewGuid().ToString(), AutoLog = false };
-                Assert.False(EventLog.SourceExists(sb.ServiceName));
-                try
-                {
-                    ServiceBase.Run(sb);
-                    Assert.False(EventLog.SourceExists(sb.ServiceName));
-                }
-                finally
-                {
-                    sb.Stop();
-                }
-            }
+            string serviceName = nameof(LogWritten_AutoLog_False) + Guid.NewGuid().ToString();
+            var testService = new TestServiceProvider(serviceName);
+            Assert.False(EventLog.SourceExists(serviceName));
+            testService.DeleteTestServices();
         }
-        
+
         [ConditionalFact(nameof(IsProcessElevated))]
+        [SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Full Framework receives the Connected Byte Code after the Exception Thrown Byte Code")]
         public void PropagateExceptionFromOnStart()
         {
             string serviceName = nameof(PropagateExceptionFromOnStart) + Guid.NewGuid().ToString();
-            TestServiceProvider _testService = new TestServiceProvider(serviceName);
-            _testService.Client.Connect(connectionTimeout);
-            Assert.Equal((int)PipeMessageByteCode.Connected, _testService.GetByte());
-            Assert.Equal((int)PipeMessageByteCode.ExceptionThrown, _testService.GetByte());
-            _testService.DeleteTestServices();
+            var testService = new TestServiceProvider(serviceName);
+            testService.Client.Connect(connectionTimeout);
+            Assert.Equal((int)PipeMessageByteCode.Connected, testService.GetByte());
+            Assert.Equal((int)PipeMessageByteCode.ExceptionThrown, testService.GetByte());
+            testService.DeleteTestServices();
         }
 
         private ServiceController ConnectToServer()

src/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/Helpers.cs

@@ -4,15 +4,14 @@
 
 namespace System.ServiceProcess.Tests
 {
-    [Flags]
     public enum PipeMessageByteCode
     {
-        Start = 0,
-        Continue = 1,
-        Pause = 2,
-        Stop = 4,
-        OnCustomCommand = 8,
-        ExceptionThrown = 16,
-        Connected = 32
+        Start,
+        Continue,
+        Pause,
+        Stop,
+        OnCustomCommand,
+        ExceptionThrown,
+        Connected
     };
 }

src/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/Program.cs

@@ -31,6 +31,12 @@ static int Main(string[] args)
                         }
                     }
                 }
+                else if (args[0].StartsWith("LogWritten"))
+                {
+                    testService = new TestService(args[0], throwException: null);
+                    testService.AutoLog = false;
+                    ServiceBase.Run(testService);
+                }
                 else
                 {
                     testService = new TestService(args[0]);

src/System.ServiceProcess.ServiceController/tests/System.ServiceProcess.ServiceController.TestService/TestServiceInstaller.cs

@@ -11,8 +11,6 @@ namespace System.ServiceProcess.Tests
 {
     public class TestServiceInstaller
     {
-        public const string LocalServiceName = "NT AUTHORITY\\LocalService";
-
         public TestServiceInstaller()
         {
         }
@@ -38,11 +36,6 @@ public unsafe void Install()
             string username = Username;
             string password = Password;
 
-            if (string.IsNullOrEmpty(username))
-            {
-                username = LocalServiceName;
-            }
-
             if (ServiceCommandLine == null)
             {
                 string processName = Process.GetCurrentProcess().MainModule.FileName;
@@ -202,4 +195,4 @@ private void DeleteService()
             }
         }
     }
-}
+}

src/System.ServiceProcess.ServiceController/tests/TestServiceProvider.cs

@@ -12,6 +12,7 @@ namespace System.ServiceProcess.Tests
     internal sealed class TestServiceProvider
     {
         private const int readTimeout = 60000;
+        public const string LocalServiceName = "NT AUTHORITY\\LocalService";
 
         private static readonly Lazy<bool> s_runningWithElevatedPrivileges = new Lazy<bool>(
             () => new WindowsPrincipal(WindowsIdentity.GetCurrent()).IsInRole(WindowsBuiltInRole.Administrator));
@@ -47,6 +48,7 @@ public NamedPipeClientStream Client
         public readonly string TestMachineName;
         public readonly TimeSpan ControlTimeout;
         public readonly string TestServiceName;
+        public readonly string Username;
         public readonly string TestServiceDisplayName;
 
         private readonly TestServiceProvider _dependentServices;
@@ -63,12 +65,13 @@ public TestServiceProvider()
             CreateTestServices();
         }
 
-        public TestServiceProvider(string serviceName)
+        public TestServiceProvider(string serviceName, string userName = LocalServiceName)
         {
             TestMachineName = ".";
             ControlTimeout = TimeSpan.FromSeconds(120);
             TestServiceName = serviceName;
             TestServiceDisplayName = "Test Service " + TestServiceName;
+            Username = userName; 
 
             // Create the service
             CreateTestServices();
@@ -92,6 +95,7 @@ private void CreateTestServices()
             testServiceInstaller.ServiceName = TestServiceName;
             testServiceInstaller.DisplayName = TestServiceDisplayName;
             testServiceInstaller.Description = "__Dummy Test Service__";
+            testServiceInstaller.Username = Username;
 
             if (_dependentServices != null)
             {