Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit a405d4d

Browse files
ViktorHoferdanmoseley
authored andcommitted
Cross framework serialization finish up (#20870)
* wip: add stubs for custom isEqual * Updated blobs, small code refactoring, disabled CookieContainer test * Fixed netfx471 detection * add custom equals for graph with cycles * fix few more comparers * Merge * fix few more test cases * fix few more types, fix GetExtensionMethod to work with parameters with same type name but different generic params * finish tests (2 comparisons are commented out: search for TODO) * Adding TypeForward for DictionaryNode * Updating blobs * Update Cookie hashes, adding TypeForwards, removing unnecessary equality checks for CookieCollection * Reenabling SortedDictionary test * Update blobs * make cookie.Timestamp to roundtrip correctly * regenerate netfx and corefx blobs to account for Cookie.Timestamp change * make regex fix the blob for ObjectWithArray * fix ObjectWithArray netfx test failure * Replacing Dictionary with Hashtable for desktop serialization support * Update blobs * Fixing a lot of TypeForwards, adding another hashtable test, other fixes * Adding a few more TypeForwardedFrom attributes * Updating the coreclr version, disabling CookieContainer test * Update blobs * Disabling CompareInfo test --> waiting for coreclr * generate test cases * update blobs, comment out not working cases * fix null equality checks for new test cases and reenable them * PR feedback addressed * Fixed a typo... * Updating used coreclr version, enabling compareinfo test again
1 parent 1fea2b2 commit a405d4d

File tree

55 files changed

+1519
-585
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+1519
-585
lines changed

dependencies.props

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
These ref versions are pulled from https://github.com/dotnet/versions.
1010
-->
1111
<PropertyGroup>
12-
<CoreFxCurrentRef>02d899e8f3e71a4f5afbd1412aeac387e12ce973</CoreFxCurrentRef>
13-
<CoreClrCurrentRef>1621e635efcf0a895866e654db357eb3d44ad650</CoreClrCurrentRef>
14-
<CoreSetupCurrentRef>82fc1fc68bfa1d55e43913b188868879f31de8e7</CoreSetupCurrentRef>
12+
<CoreFxCurrentRef>a96e149ce150f6a15546032ca3966bf238c373fb</CoreFxCurrentRef>
13+
<CoreClrCurrentRef>ee8120953ace63e9775c84e98a6ca70d4e277657</CoreClrCurrentRef>
14+
<CoreSetupCurrentRef>156d7c16cff74e50054ed195286aa53b887501e2</CoreSetupCurrentRef>
1515
<ExternalCurrentRef>5a0606fccb09fce4b47545ae9896139acca547f5</ExternalCurrentRef>
1616
<ProjectNTfsCurrentRef>02d899e8f3e71a4f5afbd1412aeac387e12ce973</ProjectNTfsCurrentRef>
1717
<ProjectNTfsTestILCCurrentRef>02d899e8f3e71a4f5afbd1412aeac387e12ce973</ProjectNTfsTestILCCurrentRef>
@@ -22,8 +22,8 @@
2222
<!-- Auto-upgraded properties for each build info dependency. -->
2323
<PropertyGroup>
2424
<PlatformPackageVersion>2.1.0-preview1-25324-02</PlatformPackageVersion>
25-
<CoreFxExpectedPrerelease>preview1-25406-02</CoreFxExpectedPrerelease>
26-
<CoreClrPackageVersion>2.1.0-preview1-25407-01</CoreClrPackageVersion>
25+
<CoreFxExpectedPrerelease>preview1-25413-02</CoreFxExpectedPrerelease>
26+
<CoreClrPackageVersion>2.1.0-preview1-25414-05</CoreClrPackageVersion>
2727
<ExternalExpectedPrerelease>beta-25322-00</ExternalExpectedPrerelease>
2828
<ProjectNTfsExpectedPrerelease>beta-25406-00</ProjectNTfsExpectedPrerelease>
2929
<ProjectNTfsTestILCExpectedPrerelease>beta-25406-00</ProjectNTfsTestILCExpectedPrerelease>

src/Common/tests/System/PlatformDetection.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public static bool IsNetfx470OrNewer()
6666
return runningVersion != null && runningVersion >= net470;
6767
}
6868

69-
public static bool IsNetfxBelow471()
69+
public static bool IsNetfx471OrNewer()
7070
{
7171
if (!IsFullFramework)
7272
{
@@ -75,7 +75,7 @@ public static bool IsNetfxBelow471()
7575

7676
Version net471 = new Version(4, 7, 1);
7777
Version runningVersion = GetFrameworkVersion();
78-
return runningVersion != null && runningVersion < net471;
78+
return runningVersion != null && runningVersion >= net471;
7979
}
8080

8181
public static Version GetFrameworkVersion()

src/System.Collections.NonGeneric/src/System/Collections/Queue.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@ namespace System.Collections
2424
[System.Runtime.CompilerServices.TypeForwardedFrom("mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089")]
2525
public class Queue : ICollection, ICloneable
2626
{
27-
private Object[] _array;
28-
private int _head; // First valid element in the queue
29-
private int _tail; // Last valid element in the queue
30-
private int _size; // Number of elements.
31-
private int _growFactor; // 100 == 1.0, 130 == 1.3, 200 == 2.0
32-
private int _version;
27+
private Object[] _array; // Do not rename (binary serialization)
28+
private int _head; // First valid element in the queue. Do not rename (binary serialization)
29+
private int _tail; // Last valid element in the queue. Do not rename (binary serialization)
30+
private int _size; // Number of elements. Do not rename (binary serialization)
31+
private int _growFactor; // 100 == 1.0, 130 == 1.3, 200 == 2.0. Do not rename (binary serialization)
32+
private int _version; // Do not rename (binary serialization)
3333
[NonSerialized]
3434
private Object _syncRoot;
3535

0 commit comments

Comments
 (0)