Search/replace Debug.Assert(false, => Debug.Fail(

Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>

Author: jkotas

src/Common/src/CoreLib/System/Convert.cs

@@ -2902,7 +2902,7 @@ private static unsafe Int32 FromBase64_Decode(Char* startInputPtr, Int32 inputLe
             }  // unchecked while
 
         // 'd be nice to have an assert that we never get here, but CS0162: Unreachable code detected.
-        // Debug.Assert(false, "We only leave the above loop by jumping; should never get here.");
+        // Debug.Fail("We only leave the above loop by jumping; should never get here.");
 
         // We jump here out of the loop if we hit an '=':
         _EqualityCharEncountered:

src/Common/src/CoreLib/System/Diagnostics/Tracing/EventSource.cs

@@ -4025,7 +4025,7 @@ static private int GetHelperCallFirstArg(MethodInfo method)
                             goto default;
                         break;
                     default:
-                        /* Debug.Assert(false, "Warning: User validation code sub-optimial: Unsuported opcode " + instrs[idx] +
+                        /* Debug.Fail("Warning: User validation code sub-optimial: Unsuported opcode " + instrs[idx] +
                             " at " + idx + " in method " + method.Name); */
                         return -1;
                 }
@@ -4617,7 +4617,7 @@ private static void RemoveReferencesToListenerInEventSources(EventListener liste
                             EventDispatcher cur = prev.m_Next;
                             if (cur == null)
                             {
-                                Debug.Assert(false, "EventSource did not have a registered EventListener!");
+                                Debug.Fail("EventSource did not have a registered EventListener!");
                                 break;
                             }
                             if (cur.m_Listener == listenerToRemove)

src/Common/src/CoreLib/System/Globalization/CalendarData.Unix.cs

@@ -325,7 +325,7 @@ private static void EnumCalendarInfoCallback(string calendarString, IntPtr conte
             }
             catch (Exception e)
             {
-                Debug.Assert(false, e.ToString());
+                Debug.Fail(e.ToString());
                 // we ignore the managed exceptions here because EnumCalendarInfoCallback will get called from the native code.
                 // If we don't ignore the exception here that can cause the runtime to fail fast.
             }

src/Common/src/CoreLib/System/Globalization/CalendarData.cs

@@ -105,7 +105,7 @@ internal CalendarData(String localeName, CalendarId calendarId, bool bUseUserOve
 
             if (!LoadCalendarDataFromSystem(localeName, calendarId))
             {
-                Debug.Assert(false, "[CalendarData] LoadCalendarDataFromSystem call isn't expected to fail for calendar " + calendarId + " locale " + localeName);
+                Debug.Fail("[CalendarData] LoadCalendarDataFromSystem call isn't expected to fail for calendar " + calendarId + " locale " + localeName);
 
                 // Something failed, try invariant for missing parts
                 // This is really not good, but we don't want the callers to crash.

src/Common/src/CoreLib/System/Globalization/CalendricalCalculationsHelper.cs

@@ -215,7 +215,7 @@ private static double EphemerisCorrection(double time)
                 }
             }
 
-            Debug.Assert(false, "Not expected to come here");
+            Debug.Fail("Not expected to come here");
             return DefaultEphemerisCorrection(year);
         }
 

src/Common/src/CoreLib/System/Globalization/CultureData.Unix.cs

@@ -148,7 +148,7 @@ private string GetLocaleInfo(string localeName, LocaleStringData type)
             {
                 // Failed, just use empty string
                 StringBuilderCache.Release(sb);
-                Debug.Assert(false, "[CultureData.GetLocaleInfo(LocaleStringData)] Failed");
+                Debug.Fail("[CultureData.GetLocaleInfo(LocaleStringData)] Failed");
                 return String.Empty;
             }
             return StringBuilderCache.GetStringAndRelease(sb);
@@ -173,7 +173,7 @@ private int GetLocaleInfo(LocaleNumberData type)
             if (!result)
             {
                 // Failed, just use 0
-                Debug.Assert(false, "[CultureData.GetLocaleInfo(LocaleNumberData)] failed");
+                Debug.Fail("[CultureData.GetLocaleInfo(LocaleNumberData)] failed");
             }
 
             return value;
@@ -188,7 +188,7 @@ private int[] GetLocaleInfo(LocaleGroupingData type)
             bool result = Interop.GlobalizationInterop.GetLocaleInfoGroupingSizes(_sWindowsName, (uint)type, ref primaryGroupingSize, ref secondaryGroupingSize);
             if (!result)
             {
-                Debug.Assert(false, "[CultureData.GetLocaleInfo(LocaleGroupingData type)] failed");
+                Debug.Fail("[CultureData.GetLocaleInfo(LocaleGroupingData type)] failed");
             }
 
             if (secondaryGroupingSize == 0)
@@ -215,7 +215,7 @@ private string GetTimeFormatString(bool shortFormat)
             {
                 // Failed, just use empty string
                 StringBuilderCache.Release(sb);
-                Debug.Assert(false, "[CultureData.GetTimeFormatString(bool shortFormat)] Failed");
+                Debug.Fail("[CultureData.GetTimeFormatString(bool shortFormat)] Failed");
                 return String.Empty;
             }
 

src/Common/src/CoreLib/System/Globalization/DateTimeFormatInfo.cs

@@ -2839,7 +2839,7 @@ private void InsertAtCurrentHashNode(TokenHashValue[] hashTable, String str, cha
                 }
                 previousNode = temp;
             };
-            Debug.Assert(false, "The hashtable is full.  This should not happen.");
+            Debug.Fail("The hashtable is full.  This should not happen.");
         }
 
         private void InsertHash(TokenHashValue[] hashTable, String str, TokenType tokenType, int tokenValue)
@@ -2927,7 +2927,7 @@ private void InsertHash(TokenHashValue[] hashTable, String str, TokenType tokenT
                 hashcode += hashProbe;
                 if (hashcode >= TOKEN_HASH_SIZE) hashcode -= TOKEN_HASH_SIZE;
             } while (i < TOKEN_HASH_SIZE);
-            Debug.Assert(false, "The hashtable is full.  This should not happen.");
+            Debug.Fail("The hashtable is full.  This should not happen.");
         }
 
         private bool CompareStringIgnoreCaseOptimized(string string1, int offset1, int length1, string string2, int offset2, int length2)

src/Common/src/CoreLib/System/Globalization/DateTimeParse.cs

@@ -4647,7 +4647,7 @@ private static Exception GetDateTimeParseException(ref DateTimeResult result)
                 case ParseFailureKind.FormatBadDateTimeCalendar:
                     return new FormatException(SR.Format(SR.GetResourceString(result.failureMessageID), result.calendar));
                 default:
-                    Debug.Assert(false, "Unkown DateTimeParseFailure: " + result);
+                    Debug.Fail("Unkown DateTimeParseFailure: " + result);
                     return null;
             }
         }

src/Common/src/CoreLib/System/Lazy.cs

@@ -84,7 +84,7 @@ internal LazyHelper(LazyThreadSafetyMode mode, Exception exception)
                     break;
 
                 default:
-                    Debug.Assert(false, "internal constructor, this should never occur");
+                    Debug.Fail("internal constructor, this should never occur");
                     break;
             }
 
@@ -119,7 +119,7 @@ private LazyThreadSafetyMode GetMode()
                     return LazyThreadSafetyMode.ExecutionAndPublication;
 
                 default:
-                    Debug.Assert(false, "Invalid logic; State should always have a valid value");
+                    Debug.Fail("Invalid logic; State should always have a valid value");
                     return default(LazyThreadSafetyMode);
             }
         }