Changed Collection Properties.

Author: shmao

src/System.ServiceModel.Syndication/ref/System.ServiceModel.Syndication.netcoreapp.cs

@@ -23,8 +23,8 @@ public partial struct XmlUriData
     public partial class SyndicationFeed
     {
         public SyndicationLink Documentation { get{ throw null; } set{ } }
-        public System.Collections.Generic.ICollection<string> SkipDays { get { throw null; } set { } }
-        public System.Collections.Generic.ICollection<int> SkipHours { get { throw null; } set { } }
+        public System.Collections.ObjectModel.Collection<string> SkipDays { get { throw null; } }
+        public System.Collections.ObjectModel.Collection<int> SkipHours { get { throw null; } }
         public System.ServiceModel.Syndication.SyndicationTextInput TextInput { get { throw null; } set { } }
         public int TimeToLive { get { throw null; } set { } }
     }

src/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/SyndicationFeed.cs

@@ -40,8 +40,8 @@ public class SyndicationFeed : IExtensibleSyndicationObject
         // optional RSS tags
         private SyndicationLink _documentation;
         private int? _timeToLive;
-        private ICollection<int> _skipHours;
-        private ICollection<string> _skipDays;
+        private Collection<int> _skipHours;
+        private Collection<string> _skipDays;
         private SyndicationTextInput _textInput;
 
         public SyndicationFeed()
@@ -325,54 +325,50 @@ public int TimeToLive
             }
         }
 
-        internal ICollection<int> InternalSkipHours
+        internal Collection<int> InternalSkipHours
         {
             get
             {
                 return _skipHours;
             }
         }
 
-        public ICollection<int> SkipHours
+        public Collection<int> SkipHours
         {
             get
             {
                 if (_skipHours == null)
                 {
-                    _skipHours = TryReadSkipHoursFromExtension(ElementExtensions);
+                    var skipHours = new Collection<int>();
+                    TryReadSkipHoursFromExtension(ElementExtensions, skipHours);
+                    _skipHours = skipHours;
                 }
 
                 return _skipHours;
             }
-            set
-            {
-                _skipHours = value;
-            }
         }
 
-        internal ICollection<string> InternalSkipDays
+        internal Collection<string> InternalSkipDays
         {
             get
             {
                 return _skipDays;
             }
         }
 
-        public ICollection<string> SkipDays
+        public Collection<string> SkipDays
         {
             get
             {
                 if (_skipDays == null)
                 {
-                    _skipDays = TryReadSkipDaysFromExtension(ElementExtensions);
+                    var skipDays = new Collection<string>();
+                    TryReadSkipDaysFromExtension(ElementExtensions, skipDays);
+                    _skipDays = skipDays;
                 }
 
                 return _skipDays;
             }
-            set
-            {
-                _skipDays = value;
-            }
         }
 
         internal SyndicationTextInput InternalTextInput
@@ -433,16 +429,15 @@ private SyndicationLink TryReadDocumentationFromExtension(SyndicationElementExte
             }
         }
 
-        private Collection<int> TryReadSkipHoursFromExtension(SyndicationElementExtensionCollection elementExtensions)
+        private void TryReadSkipHoursFromExtension(SyndicationElementExtensionCollection elementExtensions, Collection<int> skipHours)
         {
             SyndicationElementExtension skipHoursElement = elementExtensions
                                       .Where((e) => e.OuterName == Rss20Constants.SkipHoursTag && e.OuterNamespace == Rss20Constants.Rss20Namespace)
                                       .FirstOrDefault();
 
             if (skipHoursElement == null)
-                return null;
+                return;
 
-            var skipHours = new Collection<int>();
             using (XmlReader reader = skipHoursElement.GetReader())
             {
                 reader.ReadStartElement();
@@ -474,20 +469,17 @@ private Collection<int> TryReadSkipHoursFromExtension(SyndicationElementExtensio
                     }
                 }
             }
-
-            return skipHours;
         }
 
-        private Collection<string> TryReadSkipDaysFromExtension(SyndicationElementExtensionCollection elementExtensions)
+        private void TryReadSkipDaysFromExtension(SyndicationElementExtensionCollection elementExtensions, Collection<string> skipDays)
         {
             SyndicationElementExtension skipDaysElement = elementExtensions
                                       .Where((e) => e.OuterName == Rss20Constants.SkipDaysTag && e.OuterNamespace == Rss20Constants.Rss20Namespace)
                                       .FirstOrDefault();
 
             if (skipDaysElement == null)
-                return null;
+                return;
 
-            var skipDays = new Collection<string>();
             using (XmlReader reader = skipDaysElement.GetReader())
             {
                 reader.ReadStartElement();
@@ -512,8 +504,6 @@ private Collection<string> TryReadSkipDaysFromExtension(SyndicationElementExtens
 
                 reader.ReadEndElement();
             }
-
-            return skipDays;
         }
 
         private bool checkDay(string day)