Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit b64c8b7

Browse files
committed
Don't run ImplicitlyExpandNETStandardFacades if disabled
Previously I added a safeguard to ensure ImplicitlyExpandNETStandardFacades would run before the OOB conflict resolution, but I didn't condition that on the property which disables ImplicitlyExpandNETStandardFacades. The result is that if someone was using this in a non-SDK project and tried to disable ImplicitlyExpandNETStandardFacades it wouldn't be disabled.
1 parent c95f049 commit b64c8b7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/NETStandard.Library.NETFramework/targets/NETStandard.Library.NETFramework.common.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
</Otherwise>
2525
</Choose>
2626

27-
<PropertyGroup>
27+
<PropertyGroup Condition="'$(ImplicitlyExpandNETStandardFacades)' == 'true'">
2828
<!-- Ensure this runs before conflict resolution since the added files may cause conflicts -->
2929
<HandlePackageFileConflictsDependsOn>ImplicitlyExpandNETStandardFacades;$(HandlePackageFileConflictsDependsOn)</HandlePackageFileConflictsDependsOn>
3030
</PropertyGroup>

0 commit comments

Comments
 (0)