Use stackalloc for longer SystemDirectory paths (#27204)

ViktorHofer · stephentoub · commit bdba43d52e44 · 2018-02-16T13:01:27.000-05:00
* Use stackalloc for longer SystemDirectory paths

* change stackalloc to 260
diff --git a/src/System.Runtime.Extensions/src/System/Environment.Windows.cs b/src/System.Runtime.Extensions/src/System/Environment.Windows.cs
@@ -149,8 +149,7 @@ public static string SystemDirectory
         {
             get
             {
-                // The path will likely be under 32 characters, e.g. C:\Windows\system32
-                Span<char> buffer = stackalloc char[32];
+                Span<char> buffer = stackalloc char[260];
                 int requiredSize = Interop.Kernel32.GetSystemDirectoryW(buffer);
 
                 if (requiredSize > buffer.Length)

Original file line number	Diff line number	Diff line change
`@@ -149,8 +149,7 @@ public static string SystemDirectory`
`149`	`149`	`{`
`150`	`150`	`get`
`151`	`151`	`{`
`152`		`- // The path will likely be under 32 characters, e.g. C:\Windows\system32`
`153`		`- Span<char> buffer = stackalloc char[32];`
	`152`	`+ Span<char> buffer = stackalloc char[260];`
`154`	`153`	`int requiredSize = Interop.Kernel32.GetSystemDirectoryW(buffer);`
`155`	`154`
`156`	`155`	`if (requiredSize > buffer.Length)`