Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit bf5ffea

Browse files
ViktorHoferstephentoub
authored andcommitted
Disabling xunit AppDomain in System.Configuration.ConfigurationManager in favor of consistent BaseDirectory path behavior (#19546)
* Disabled xunit AppDomain in favor of consistent BaseDirectory behavior * Activated test again * Refined XUnitNoAppdomain comment
1 parent ab1cdf1 commit bf5ffea

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/System.Configuration.ConfigurationManager/tests/System.Configuration.ConfigurationManager.Tests.csproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
<PropertyGroup>
55
<ProjectGuid>{7669C397-C21C-4C08-83F1-BE6691911E88}</ProjectGuid>
66
<TestCategories>InnerLoop;OuterLoop</TestCategories>
7+
<!-- XUnit AppDomains BaseDirectory path doesn't contain a trailing slash, which impacts our tests. -->
8+
<XUnitNoAppdomain>true</XUnitNoAppdomain>
79
</PropertyGroup>
810
<!-- Default configurations to help VS understand the options -->
911
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='netstandard-Debug|AnyCPU'" />

src/System.Configuration.ConfigurationManager/tests/System/Configuration/UrlPathTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ public void GetDirectoryOrRootName_NotDirectoryOrRoot()
2525
}
2626

2727
[Fact]
28-
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "dotnet/corefx #18196")]
2928
public void GetDirectoryOrRootName_GettingDirectoryFromAFilePath()
3029
{
3130
string exePath = AppDomain.CurrentDomain.BaseDirectory;

0 commit comments

Comments
 (0)