Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit c37edea

Browse files
authored
Disable RemoteInvoke finalizer that's wreaking havoc on CI (#27404)
* Disable RemoteInvoke finalizer that's wreaking havoc on CI * Work around code analysis error
1 parent a00ae90 commit c37edea

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/CoreFx.Private.TestUtilities/src/System/Diagnostics/RemoteExecutorTestBase.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,7 @@ public void Dispose()
209209

210210
private void Dispose(bool disposing)
211211
{
212-
// https://github.com/dotnet/corefx/issues/27366
213-
// Assert.True(disposing, $"A test {AssemblyName}!{ClassName}.{MethodName} forgot to Dispose() the result of RemoteInvoke()");
212+
Assert.True(disposing, $"A test {AssemblyName}!{ClassName}.{MethodName} forgot to Dispose() the result of RemoteInvoke()");
214213

215214
if (Process != null)
216215
{
@@ -251,12 +250,13 @@ private void Dispose(bool disposing)
251250
}
252251
}
253252

254-
~RemoteInvokeHandle()
255-
{
253+
// https://github.com/dotnet/corefx/issues/27366
254+
//~RemoteInvokeHandle()
255+
//{
256256
// Finalizer flags tests that omitted the explicit Dispose() call; they must have it, or they aren't
257257
// waiting on the remote execution
258-
Dispose(disposing: false);
259-
}
258+
// Dispose(disposing: false);
259+
//}
260260

261261
private sealed class RemoteExecutionException : XunitException
262262
{

0 commit comments

Comments
 (0)