Disable console title workaround for >=RS4 (#25532)

ViktorHofer · stephentoub · commit d1521ea6671f · 2017-11-28T20:07:48.000-05:00
* Disable console title workaround for &gt;=RS4

* Change to expect test throwing on RS2
diff --git a/src/System.Console/tests/WindowAndCursorProps.cs b/src/System.Console/tests/WindowAndCursorProps.cs
@@ -155,7 +155,7 @@ public static void Title_Set_Windows(int lengthOfTitle)
             string newTitle = new string('a', int.Parse(lengthOfTitleString));
             Console.Title = newTitle;
 
-            if (newTitle.Length > 513 && PlatformDetection.IsWindows10Version1703OrGreater)
+            if (newTitle.Length > 513 && PlatformDetection.IsWindows10Version1703OrGreater && !PlatformDetection.IsWindows10Version1709OrGreater)
             {
                 // RS2 has a bug when getting the window title when the title length is longer than 513 character
                 Assert.Throws<IOException>(() => Console.Title);

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,7 @@ public static void Title_Set_Windows(int lengthOfTitle)`
`155`	`155`	`string newTitle = new string('a', int.Parse(lengthOfTitleString));`
`156`	`156`	`Console.Title = newTitle;`
`157`	`157`
`158`		`- if (newTitle.Length > 513 && PlatformDetection.IsWindows10Version1703OrGreater)`
	`158`	`+ if (newTitle.Length > 513 && PlatformDetection.IsWindows10Version1703OrGreater && !PlatformDetection.IsWindows10Version1709OrGreater)`
`159`	`159`	`{`
`160`	`160`	`// RS2 has a bug when getting the window title when the title length is longer than 513 character`
`161`	`161`	`Assert.Throws<IOException>(() => Console.Title);`