Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit dd4519d

Browse files
authored
RefApiCompat for isolatedStorage (#28120)
1 parent 1020ce2 commit dd4519d

File tree

5 files changed

+7
-10
lines changed

5 files changed

+7
-10
lines changed
Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
Compat issues with assembly System.IO.FileSystem:
2+
# These are now virtual in the implementation, which should be ok.
23
CannotMakeMemberAbstract : Member 'System.IO.FileSystemInfo.Exists' is abstract in the implementation but is not abstract in the contract.
34
CannotMakeMemberAbstract : Member 'System.IO.FileSystemInfo.Name' is abstract in the implementation but is not abstract in the contract.
45
CannotMakeMemberAbstract : Member 'System.IO.FileSystemInfo.Exists.get()' is abstract in the implementation but is not abstract in the contract.
56
CannotMakeMemberAbstract : Member 'System.IO.FileSystemInfo.Name.get()' is abstract in the implementation but is not abstract in the contract.
6-
TypesMustExist : Type 'System.IO.Enumeration.FileSystemEntry.<_fileNameBuffer>e__FixedBuffer' does not exist in the implementation but it does exist in the contract.
7-
MembersMustExist : Member 'System.IO.Enumeration.FileSystemEnumerator<TResult>.GetData()' does not exist in the implementation but it does exist in the contract.
7+
# C# generates backing fields for fixed buffers as public.
8+
TypesMustExist : Type 'System.IO.Enumeration.FileSystemEntry.<_fileNameBuffer>e__FixedBuffer' does not exist in the implementation but it does exist in the contract.

src/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.Win32.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public partial class FileSystemEnumerator<TResult>
1111
{
1212
/// <returns>'true' if new data was found</returns>
1313
[MethodImpl(MethodImplOptions.AggressiveInlining)]
14-
public unsafe bool GetData()
14+
private unsafe bool GetData()
1515
{
1616
Debug.Assert(_directoryHandle != (IntPtr)(-1) && _directoryHandle != IntPtr.Zero && !_lastEntryFound);
1717

src/System.IO.FileSystem/src/System/IO/Enumeration/FileSystemEnumerator.WinRT.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ namespace System.IO.Enumeration
1010
public partial class FileSystemEnumerator<TResult>
1111
{
1212
[MethodImpl(MethodImplOptions.AggressiveInlining)]
13-
public unsafe bool GetData()
13+
private unsafe bool GetData()
1414
{
1515
if (!Interop.Kernel32.GetFileInformationByHandleEx(
1616
_directoryHandle,

src/System.IO.IsolatedStorage/src/MatchingRefApiCompatBaseline.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/System.IO.IsolatedStorage/src/System/IO/IsolatedStorage/IsolatedStorage.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ internal set
108108

109109
public IsolatedStorageScope Scope
110110
{
111-
get; protected set;
111+
get; private set;
112112
}
113113

114114
protected virtual char SeparatorExternal
@@ -128,7 +128,7 @@ public virtual bool IncreaseQuotaTo(long newQuotaSize)
128128

129129
public abstract void Remove();
130130

131-
protected string IdentityHash
131+
internal string IdentityHash
132132
{
133133
get; private set;
134134
}

0 commit comments

Comments
 (0)