Disable parallelization for EventLog (#25695)

Anipik · stephentoub · commit defb6d52047c · 2017-12-04T17:53:06.000-05:00
* Disabled paralllzation

* Removing active issue tests
diff --git a/src/System.Diagnostics.EventLog/tests/EventLogEntryCollectionTests.cs b/src/System.Diagnostics.EventLog/tests/EventLogEntryCollectionTests.cs
@@ -69,7 +69,6 @@ public void CheckingEntryEqualityWithNull()
             }
         }
 
-        [ActiveIssue(24874)]
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void CheckingEntryEqualityAndIndex()
         {
@@ -100,7 +99,6 @@ public void CheckingEntryEqualityAndIndex()
             }
         }
 
-        [ActiveIssue(24874)]
         [ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]
         public void CheckingEntryInEquality()
         {
diff --git a/src/System.Diagnostics.EventLog/tests/Helpers.cs b/src/System.Diagnostics.EventLog/tests/Helpers.cs
@@ -6,6 +6,9 @@
 using System.Threading;
 using Xunit;
 
+// Implementation is not robust with respect to concurrently writing and reading log
+[assembly: CollectionBehavior(DisableTestParallelization = true)]
+
 namespace System.Diagnostics.Tests
 {
     internal class Helpers

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,6 @@ public void CheckingEntryEqualityWithNull()`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`
`72`		`- [ActiveIssue(24874)]`
`73`	`72`	`[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]`
`74`	`73`	`public void CheckingEntryEqualityAndIndex()`
`75`	`74`	`{`
`@@ -100,7 +99,6 @@ public void CheckingEntryEqualityAndIndex()`
`100`	`99`	`}`
`101`	`100`	`}`
`102`	`101`
`103`		`- [ActiveIssue(24874)]`
`104`	`102`	`[ConditionalFact(typeof(Helpers), nameof(Helpers.IsElevatedAndSupportsEventLogs))]`
`105`	`103`	`public void CheckingEntryInEquality()`
`106`	`104`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,9 @@`
`6`	`6`	`using System.Threading;`
`7`	`7`	`using Xunit;`
`8`	`8`
	`9`	`+// Implementation is not robust with respect to concurrently writing and reading log`
	`10`	`+[assembly: CollectionBehavior(DisableTestParallelization = true)]`
	`11`	`+`
`9`	`12`	`namespace System.Diagnostics.Tests`
`10`	`13`	`{`
`11`	`14`	`internal class Helpers`