Porting PR 19884 SqlConnection doesn't override DbProviderFactory property (#20198)

* Implements #19825: SqlConnection doesn't override DbProviderFactory property (#19884)

* Implements #19825: SqlConnection doesn't override DbProviderFactory property

* Test added for SqlConnection.DbProviderFactory implementation for #19825

* Remove the additional fact from integ auth test

Author: saurabh500

src/System.Data.SqlClient/src/System/Data/SqlClient/SqlConnection.cs

@@ -316,6 +316,11 @@ public string WorkstationId
             }
         }
 
+        protected override DbProviderFactory DbProviderFactory
+        {
+            get { return SqlClientFactory.Instance; }
+        }
+
         // SqlCredential: Pair User Id and password in SecureString which are to be used for SQL authentication
 
         //

src/System.Data.SqlClient/tests/FunctionalTests/SqlConnectionTest.cs

@@ -3,6 +3,8 @@
 // See the LICENSE file in the project root for more information.
 
 
+using System.Data.Common;
+using System.Reflection;
 using Xunit;
 
 namespace System.Data.SqlClient.Tests
@@ -36,6 +38,17 @@ public void IntegratedAuthConnectionTest()
                 }
             }
         }
-    }
 
+        [Fact]
+        public void SqlConnectionDbProviderFactoryTest()
+        {
+            SqlConnection con = new SqlConnection();
+            PropertyInfo dbProviderFactoryProperty = con.GetType().GetProperty("DbProviderFactory", BindingFlags.NonPublic | BindingFlags.Instance);
+            Assert.NotNull(dbProviderFactoryProperty);
+            DbProviderFactory factory = dbProviderFactoryProperty.GetValue(con) as DbProviderFactory;
+            Assert.NotNull(factory);
+            Assert.Same(typeof(SqlClientFactory), factory.GetType());
+            Assert.Same(SqlClientFactory.Instance, factory);
+        }
+    }
 }