Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit eb2025d

Browse files
committed
Add an empty dependency group for net45 to DataFlow package
DataFlow has assets that are netstandard and old PCL and corrisponding dependencies. However when selecting for .NET Framework we can eliminate the dependencies as they aren't necessary as we know they all exist already in framework. Fixes https://github.com/dotnet/corefx/issues/25171
1 parent 4350f2d commit eb2025d

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/System.Threading.Tasks.Dataflow/pkg/System.Threading.Tasks.Dataflow.pkgproj

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,20 @@
1212

1313
<!-- Since UAP and .NETCoreApp are package based we still want to enable
1414
OOBing libraries that happen to overlap with their framework package.
15-
This avoids us having to lock the API in our NuGet packages just
16-
to match what shipped inbox: since we can provide a new library
15+
This avoids us having to lock the API in our NuGet packages just
16+
to match what shipped inbox: since we can provide a new library
1717
we can update it to add API without raising the netstandard version. -->
1818
<ValidatePackageSuppression Include="TreatAsOutOfBox">
1919
<Value>.NETCoreApp;UAP</Value>
2020
</ValidatePackageSuppression>
21+
22+
<!--
23+
Include empty dependency group for net45 and higher to avoid unncessary package dependencies
24+
because all the dependencies are known to be inbox already.
25+
-->
26+
<Dependency Include="_._">
27+
<TargetFramework>net45</TargetFramework>
28+
</Dependency>
2129
</ItemGroup>
2230
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
2331
</Project>

0 commit comments

Comments
 (0)