This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Commit ef03e59
Corrected DataTable deserialization to use invariant culture for schema properties (#26298)
* Updated schema property processing in the XMLSchema and XSDSchema types in XMLSchema.cs.
Added unit tests to verify that culture settings are ignored both in serialization and deserialization of XML schemas, as employed by the serialization of DataTable objects.
* Updated the XsdSchemaDeserializationIgnoresLocale test to be skipped on the full framework, and added test XsdSchemaDeserializationOnFullFrameworkStillHasBug to only run on the full framework to ensure we get alerted when the full framework does get the fix, so that the main test can be re-enabled there.
* Updated DataTableReadXmlSchemaTest.cs to run the XsdSchemaSerializationIgnoresLocale and XsdSchemaDeserializationIgnoresLocale tests, which modify the current culture, out-of-process using RemoteExecutorTestBase. (The XsdSchemaDeserializationOnFullFrameworkStillHasBug still runs in-process, as that test only runs on the full framework anyway.)
* Applied code style recommendations from @ViktorHofer.
Corrected the XsdSchemaDeserializationOnFullFrameworkStillHasBug test to restore the culture after verifying the exception.1 parent 1354c63 commit ef03e59
File tree
2 files changed
+252
-3
lines changed- src/System.Data.Common
- src/System/Data
- tests/System/Data
2 files changed
+252
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| |||
298 | 298 | | |
299 | 299 | | |
300 | 300 | | |
301 | | - | |
| 301 | + | |
302 | 302 | | |
303 | 303 | | |
304 | 304 | | |
| |||
0 commit comments