Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit f79a893

Browse files
committed
Moving CompileDeepTree_NoStackOverflowFast to the outer loop
It appears that the test equally stresses the Expression Tree Compiler and the JIT compiler. Normally this is not a problem since JIT compiler uses much less resources that ET compiler and 128Kb of stack is more than enough to JIT the resulting method. That does not seem to be the case when running on Debug and the test may fail on debug runtime/JIT We generally want the inner loop to pass on Debug though, so the test should be moved to the outer loop.
1 parent 6437e60 commit f79a893

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/System.Linq.Expressions/tests/CompilerTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ public static void CompileDeepTree_NoStackOverflow(bool useInterpreter)
2828
}
2929

3030
[Theory, ClassData(typeof(CompilationTypes))]
31+
[OuterLoop("May fail with SO on Debug JIT")]
3132
public static void CompileDeepTree_NoStackOverflowFast(bool useInterpreter)
3233
{
3334
Expression e = Expression.Constant(0);

0 commit comments

Comments
 (0)