Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit fbb328b

Browse files
authored
replace issue number (#28036)
1 parent e3036d2 commit fbb328b

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

src/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Authentication.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public async Task HttpClientHandler_Authentication_Succeeds(string authenticateH
3636
{
3737
if (PlatformDetection.IsWindowsNanoServer || (IsCurlHandler && authenticateHeader.ToLowerInvariant().Contains("digest")))
3838
{
39-
// TODO: #27113: Fix failing authentication test cases on different httpclienthandlers.
39+
// TODO: #28065: Fix failing authentication test cases on different httpclienthandlers.
4040
return;
4141
}
4242

@@ -63,7 +63,7 @@ public async void HttpClientHandler_MultipleAuthenticateHeaders_WithSameAuth_Suc
6363
{
6464
if (IsWinHttpHandler)
6565
{
66-
// TODO: #27113: Fix failing authentication test cases on different httpclienthandlers.
66+
// TODO: #28065: Fix failing authentication test cases on different httpclienthandlers.
6767
return;
6868
}
6969

@@ -77,7 +77,7 @@ public async Task HttpClientHandler_MultipleAuthenticateHeaders_Succeeds(string
7777
{
7878
if (PlatformDetection.IsWindowsNanoServer || (IsCurlHandler && authenticateHeader.Contains("Digest")))
7979
{
80-
// TODO: #27113: Fix failing authentication test cases on different httpclienthandlers.
80+
// TODO: #28065: Fix failing authentication test cases on different httpclienthandlers.
8181
return;
8282
}
8383

@@ -114,7 +114,7 @@ public static IEnumerable<object[]> Authentication_TestData()
114114
yield return new object[] { "basic", true };
115115

116116
// Add digest tests fail on CurlHandler.
117-
// TODO: #27113: Fix failing authentication test cases on different httpclienthandlers.
117+
// TODO: #28065: Fix failing authentication test cases on different httpclienthandlers.
118118
yield return new object[] { "Digest realm=\"testrealm\" nonce=\"testnonce\"", false };
119119
yield return new object[] { $"Digest realm=\"testrealm\", nonce=\"{Convert.ToBase64String(Encoding.UTF8.GetBytes($"{DateTimeOffset.UtcNow}:XMh;z+$5|`i6Hx}}\", qop=auth-int, algorithm=MD5"))}\"", true };
120120
yield return new object[] { "Digest realm=\"api@example.org\", qop=\"auth\", algorithm=MD5-sess, nonce=\"5TsQWLVdgBdmrQ0XsxbDODV+57QdFR34I9HAbC/RVvkK\", " +
@@ -126,8 +126,7 @@ public static IEnumerable<object[]> Authentication_TestData()
126126

127127
if (PlatformDetection.IsNetCore)
128128
{
129-
// These fail on full framework runs.
130-
// TODO: #27113: Fix failing authentication test cases on different httpclienthandlers.
129+
// TODO: #28060: Fix failing authentication test cases on Framework run.
131130
yield return new object[] { "Digest realm=\"testrealm1\", nonce=\"testnonce1\" Digest realm=\"testrealm2\", nonce=\"testnonce2\"", false };
132131
yield return new object[] { "Basic something, Digest something", false };
133132
yield return new object[] { $"Digest realm=\"testrealm\", nonce=\"testnonce\", algorithm=MD5 " +

src/System.Net.Http/tests/FunctionalTests/SocketsHttpHandlerTest.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ public async void SocketsHttpHandler_Authentication_Succeeds(string authenticate
559559
public static IEnumerable<object[]> Authentication_SocketsHttpHandler_TestData()
560560
{
561561
// These test cases pass on SocketsHttpHandler, fail everywhere else.
562-
// TODO: #27113: Fix failing authentication test cases on different httpclienthandlers.
562+
// TODO: #28065: Investigate failing authentication test cases on WinHttpHandler & CurlHandler.
563563
yield return new object[] { "Basic realm=\"testrealm1\" basic realm=\"testrealm1\"", true };
564564
yield return new object[] { "Basic something digest something", true };
565565
yield return new object[] { "Digest ", false };

0 commit comments

Comments
 (0)