Letting perfproc errors pass silently (#19495)

* Letting perfproc errors pass silently

* Removed registry detection for now

Author: ViktorHofer

src/System.Diagnostics.Process/tests/ProcessTests.cs

@@ -873,12 +873,19 @@ public void GetProcessesByName_ProcessNameMachineName_ReturnsExpected(string mac
             Assert.All(processes, process => Assert.Equal(machineName, process.MachineName));
         }
 
-        [ConditionalTheory(nameof(ProcessPerformanceCounterEnabled))]
         [MemberData(nameof(MachineName_Remote_TestData))]
         [PlatformSpecific(TestPlatforms.Windows)] // Accessing processes on remote machines is only supported on Windows.
         public void GetProcessesByName_RemoteMachineNameWindows_ReturnsExpected(string machineName)
         {
-            GetProcessesByName_ProcessNameMachineName_ReturnsExpected(machineName);
+            try
+            {
+                GetProcessesByName_ProcessNameMachineName_ReturnsExpected(machineName);
+            }
+            catch (InvalidOperationException)
+            {
+                // As we can't detect reliably if performance counters are enabled 
+                // we let possible InvalidOperationExceptions pass silently.
+            }
         }
 
         [Theory]
@@ -911,46 +918,34 @@ public void GetProcessesByName_EmptyMachineName_ThrowsArgumentException()
             Assert.Throws<ArgumentException>(null, () => Process.GetProcessesByName(currentProcess.ProcessName, ""));
         }
 
-        public static IEnumerable<object[]> GetTestProcess()
+        [PlatformSpecific(TestPlatforms.Windows)]  // Behavior differs on Windows and Unix
+        [SkipOnTargetFramework(TargetFrameworkMonikers.UapAot, "https://github.com/dotnet/corefx/issues/18212")]
+        public void TestProcessOnRemoteMachineWindows()
         {
-            Process currentProcess = Process.GetCurrentProcess();
-            yield return new object[] { currentProcess, Process.GetProcessById(currentProcess.Id, "127.0.0.1") };
-            yield return new object[] { currentProcess, Process.GetProcessesByName(currentProcess.ProcessName, "127.0.0.1").Where(p => p.Id == currentProcess.Id).Single() };
-        }
+            Process currentProccess = Process.GetCurrentProcess();
+
+            void TestRemoteProccess(Process remoteProcess)
+            {
+                Assert.Equal(currentProccess.Id, remoteProcess.Id);
+                Assert.Equal(currentProccess.BasePriority, remoteProcess.BasePriority);
+                Assert.Equal(currentProccess.EnableRaisingEvents, remoteProcess.EnableRaisingEvents);
+                Assert.Equal("127.0.0.1", remoteProcess.MachineName);
+                // This property throws exception only on remote processes.
+                Assert.Throws<NotSupportedException>(() => remoteProcess.MainModule);
+            }
 
-        private static bool ProcessPerformanceCounterEnabled()
-        {
             try
             {
-                using (Microsoft.Win32.RegistryKey perfKey = Microsoft.Win32.Registry.LocalMachine.OpenSubKey(@"SYSTEM\CurrentControlSet\Services\PerfProc\Performance"))
-                {
-                    if (perfKey == null)
-                        return false;
-                    int? value = (int?)perfKey.GetValue("Disable Performance Counters", null);
-                    return !value.HasValue || value.Value == 0;
-                }
+                TestRemoteProccess(Process.GetProcessById(currentProccess.Id, "127.0.0.1"));
+                TestRemoteProccess(Process.GetProcessesByName(currentProccess.ProcessName, "127.0.0.1").Where(p => p.Id == currentProccess.Id).Single());
             }
-            catch (Exception)
+            catch (InvalidOperationException)
             {
-                // Ignore exceptions, and just assume the counter is disabled.
-                return false;
+                // As we can't detect reliably if performance counters are enabled 
+                // we let possible InvalidOperationExceptions pass silently.
             }
         }
 
-        [PlatformSpecific(TestPlatforms.Windows)]  // Behavior differs on Windows and Unix
-        [ConditionalTheory(nameof(ProcessPerformanceCounterEnabled))]
-        [SkipOnTargetFramework(TargetFrameworkMonikers.UapAot, "https://github.com/dotnet/corefx/issues/18212")]
-        [MemberData(nameof(GetTestProcess))]
-        public void TestProcessOnRemoteMachineWindows(Process currentProcess, Process remoteProcess)
-        {
-            Assert.Equal(currentProcess.Id, remoteProcess.Id);
-            Assert.Equal(currentProcess.BasePriority, remoteProcess.BasePriority);
-            Assert.Equal(currentProcess.EnableRaisingEvents, remoteProcess.EnableRaisingEvents);
-            Assert.Equal("127.0.0.1", remoteProcess.MachineName);
-            // This property throws exception only on remote processes.
-            Assert.Throws<NotSupportedException>(() => remoteProcess.MainModule);
-        }
-
         [Fact, PlatformSpecific(TestPlatforms.AnyUnix)]  // Behavior differs on Windows and Unix
         public void TestProcessOnRemoteMachineUnix()
         {