Latency plugin maxes out at 10 seconds

[rcrowley-camp]

Why is there such a low max delay in the latency plugin? I would like to observe a timeout in my app but it will never happen within 10 seconds.

[garrytrinder]

We don't set a limit on the plugin for maxMs, we only set maxMs to 5000 when not provided in the config.

dev-proxy/DevProxy.Plugins/Behavior/LatencyPlugin.cs

Lines 12 to 16 in bb09f96

	public sealed class LatencyConfiguration
	{
	public int MinMs { get; set; }
	public int MaxMs { get; set; } = 5000;
	}

The maxMs value is passed to Task.Delay() method.

dev-proxy/DevProxy.Plugins/Behavior/LatencyPlugin.cs

Lines 47 to 49 in bb09f96

	var delay = _random.Next(Configuration.MinMs, Configuration.MaxMs);
	Logger.LogRequest($"Delaying request for {delay}ms", MessageType.Chaos, new(e.Session));
	await Task.Delay(delay, cancellationToken);

The below config allowed me to delay all requests up to 20 seconds.

{
  "$schema": "https://raw.githubusercontent.com/microsoft/dev-proxy/main/schemas/v1.3.0/rc.schema.json",
  "plugins": [
    {
      "name": "LatencyPlugin",
      "enabled": true,
      "pluginPath": "~appFolder/plugins/DevProxy.Plugins.dll",
      "configSection": "latencyPlugin"
    }
  ],
  "urlsToWatch": [
    "https://*"
  ],
  "latencyPlugin": {
    "minMs": 0,
    "maxMs": 20000
  }
}

I could see in the output that requests were delayed longer than 10 seconds.

It looks like we have included the max limit in docs incorrectly, I'll raise a PR to remove the limit from docs.

[rcrowley-camp]

But I get this error:

 fail    Plugin configuration validation failed with the following errors: Integer 50000 exceeds maximum value of 10000. Path 'maxMs', line 4, position 22. 
 info    New Dev Proxy version v2.0.0 is available.
See https://aka.ms/devproxy/upgrade for more information.
 info    Dev Proxy API listening on http://127.0.0.1:8897...
 info    Dev Proxy listening on 127.0.0.1:8000...

Hotkeys: issue (w)eb request, (r)ecord, (s)top recording, (c)lear screen
Press CTRL+C to stop Dev Proxy

I'm using v1.3.0 and this is my config:

{
    "$schema": "https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v1.3.0/rc.schema.json",
    "plugins": [
        {
            "name": "LatencyPlugin",
            "enabled": true,
            "pluginPath": "~appFolder/plugins/DevProxy.Plugins.dll",
            "configSection": "latencyPlugin"
        }
    ],
    "urlsToWatch": [
        "elided"
    ],
    "latencyPlugin": {
        "$schema": "https://raw.githubusercontent.com/dotnet/dev-proxy/main/schemas/v1.3.0/latencyplugin.schema.json",
        "minMs": 9000,
        "maxMs": 50000
    },
    "logLevel": "information",
    "newVersionNotification": "stable",
    "showSkipMessages": true
}

Update: same experience on v2.0.0

[garrytrinder]

Ah I see why, you have the $schema on the config section and it's failing validation.

Can you remove the $schema property and try again.

[rcrowley-camp]

Bingo! I just accepted what the VC code extension or maybe Copilot dumped without checking. Thanks!

[garrytrinder]

The extension is correct, but our schema validation is forcing you to a limit of 10 seconds.

I've raised a PR to remove that limit. For now, use without $schema as the workaround and we will ship the update in the next version. Thanks for reaching out and sorry for the trouble.