[main] Update Image Builder tag reference #1710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-docker-bot
force-pushed
the
docker-tools-main-image-builder-tag
branch
from
d2c6393 to
2bf0383
Compare
dotnet-docker-bot
force-pushed
the
docker-tools-main-image-builder-tag
branch
from
2bf0383 to
7b245f7
Compare
lbussell
force-pushed
the
docker-tools-main-image-builder-tag
branch
from
24cd703 to
7b1d3fe
Compare
lbussell
reviewed
May 28, 2025
lbussell
reviewed
May 28, 2025
Comment on lines
+62
to
66
| '-e SYSTEM_ACCESSTOKEN=$(System.AccessToken)' | ||
| '-e SYSTEM_OIDCREQUESTURI=$(System.OidcRequestUri)' | ||
| ) | ||
| $dockerRunCmd = $dockerRunBaseCmd + $dockerRunArgs |
There was a problem hiding this comment.
I think some or all of this step (Define ImageBuilder Command Variables) could now be embedded directly into run-imagebuilder.yml.
lbussell
reviewed
May 28, 2025
|
/cc @dagood @gdams more breaking changes coming down the line. We have changed the way auth works in ImageBuilder. You will need a few more values for each service connection - Service Connection ID, Tenant ID, and Client ID. You can find all of these in the Service Connection's "edit" menu. Format TBD - you will either need to specify these via pipeline template parameter or more pipeline variables. |
mthalman
approved these changes
May 29, 2025
This was referenced May 29, 2025
lbussell
added a commit
to lbussell/docker-tools
that referenced
this pull request
Jun 9, 2025
This reverts commit 052f71e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the common pipeline variables to reference an updated tag of Image Builder.