Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 20, 2025

  • Review PR #12137 details and understand API changes
  • Create breaking-changes article in docs/compatibility/13.0/ directory
  • Update docs/fundamentals/custom-deployments.md to reflect new API names and usage patterns
  • Update docs/extensibility/interaction-service.md to reflect new context types
  • Add new breaking change to compatibility/toc.yml
  • Create index.md for 13.0 version
  • Build and validate documentation locally (markdown linting passed, YAML validation passed)
  • Address code review feedback (parameter naming consistency)
  • Fix cross reference warnings by replacing xref tags with inline code formatting
Original prompt

Please create a breaking-changes article that covers the API changes in @dotnet/aspire/pull/12137 - Also, please update the ./fundamentals/custom-deployments.md and ./extensibility/interaction-service.md articles accordingly.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


Internal previews

📄 File 🔗 Preview link
docs/compatibility/13.0/index.md docs/compatibility/13.0/index
docs/compatibility/13.0/pipeline-activity-reporter-renamed.md docs/compatibility/13.0/pipeline-activity-reporter-renamed
docs/compatibility/toc.yml docs/compatibility/toc
docs/extensibility/interaction-service.md docs/extensibility/interaction-service
docs/fundamentals/custom-deployments.md docs/fundamentals/custom-deployments

Copilot AI and others added 3 commits October 20, 2025 15:11
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copilot AI changed the title [WIP] Update breaking changes article and documentation Add breaking changes documentation for pipeline activity reporter API rename (PR #12137) Oct 20, 2025
Copilot AI requested a review from IEvangelist October 20, 2025 15:18
Copilot finished work on behalf of IEvangelist October 20, 2025 15:18
@IEvangelist
Copy link
Member

Hey @copilot please address these warnings:

./compatibility/13.0/pipeline-activity-reporter-renamed.md
Line 136: [Warning] Cross reference not found: 'Aspire.Hosting.Publishing.PublishingActivityReporter'.
Line 140: [Warning] Cross reference not found: 'Aspire.Hosting.Publishing.PublishingStep'.
Line 141: [Warning] Cross reference not found: 'Aspire.Hosting.Publishing.PublishingTask'.
./fundamentals/custom-deployments.md
Line 17: [Warning] Cross reference not found: 'Aspire.Hosting.Pipelines.IPipelineActivityReporter'.

Please just remove the xref for now and instead wrap the type in code, for example IPipelineActivityReporter.

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 21, 2025

Hey @copilot please address these warnings:

./compatibility/13.0/pipeline-activity-reporter-renamed.md
...

Fixed in commit 7c8df56. Replaced the failing xref tags with inline code formatting for PublishingActivityReporter, PublishingStep, PublishingTask, and IPipelineActivityReporter.

Copilot finished work on behalf of IEvangelist October 21, 2025 20:08
@IEvangelist IEvangelist marked this pull request as ready for review October 24, 2025 23:49
@IEvangelist IEvangelist merged commit 24edde9 into release-13 Oct 24, 2025
7 checks passed
@IEvangelist IEvangelist deleted the copilot/update-breaking-changes-article branch October 24, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants