Skip to content

Conversation

@adegeo
Copy link
Contributor

@adegeo adegeo commented Dec 7, 2021

Summary

Fixes #1211

@IEvangelist ready for review

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time @adegeo, please try to limit the amount of changes in your PRs. This PR has a staggering amount of code changes to review, and was very time consuming to review. It might be best in the future to have smaller, more targeted incremental PRs. We'll :shipit:

@adegeo adegeo merged commit 023dac5 into main Dec 8, 2021
@adegeo adegeo deleted the adegeo-1211 branch December 8, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in the page

3 participants