Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Dec 28, 2021

@adegeo, this PR is ready for your review.

This article version adds much needed code snippets to help explain the concepts.

Some VB project XAML is commented out because, unlike C# project XAML, Visual Studio wouldn't recognize locally defined code-behind classes. If you know how to make that work in VB, please share.

Internal preview link

@ghost ghost marked this pull request as ready for review December 29, 2021 23:51
Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Few things to handle. In the VB project I discovered:

  1. You added a namespace declaration to the MainWindow.xaml.vb file. VB.NET uses implicit namespaces so every file is already in the <RootNamespace> value for the project. So with the added namespace, the control is actually in the clr-namespace:CodeSampleVb.CodeSampleVb namespace.

  2. There does seem to be some sort of bug though related to controls created this way. Once the xmlns:local was fixed, it still gave an error. This was due to the x:Name property for some reason. I have no idea why. I'll replicate it in a clean project and then file a bug with Visual Studio. you can just delete x:Name from the element and it will compile correctly.

@adegeo
Copy link
Contributor

adegeo commented Jan 5, 2022

@v-trisshores Ok the last PR was merged so this is ready for conflict resolution 😁

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whooops, I meant to just change the request info, not approve it. Just waiting on merge conflict and VBCode fix.

@ghost ghost closed this Jan 5, 2022
@ghost ghost reopened this Jan 5, 2022
@ghost
Copy link
Author

ghost commented Jan 5, 2022

@adegeo, thank you - this should be ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants