-
Couldn't load subscription status.
- Fork 183
Content update - Property value inheritance (user story 1878471) #1261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Few things to handle. In the VB project I discovered:
-
You added a namespace declaration to the MainWindow.xaml.vb file. VB.NET uses implicit namespaces so every file is already in the
<RootNamespace>value for the project. So with the added namespace, the control is actually in theclr-namespace:CodeSampleVb.CodeSampleVbnamespace. -
There does seem to be some sort of bug though related to controls created this way. Once the
xmlns:localwas fixed, it still gave an error. This was due to thex:Nameproperty for some reason. I have no idea why. I'll replicate it in a clean project and then file a bug with Visual Studio. you can just deletex:Namefrom the element and it will compile correctly.
|
@v-trisshores Ok the last PR was merged so this is ready for conflict resolution 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whooops, I meant to just change the request info, not approve it. Just waiting on merge conflict and VBCode fix.
|
@adegeo, thank you - this should be ready to merge. |
@adegeo, this PR is ready for your review.
This article version adds much needed code snippets to help explain the concepts.
Some VB project XAML is commented out because, unlike C# project XAML, Visual Studio wouldn't recognize locally defined code-behind classes. If you know how to make that work in VB, please share.
Internal preview link