Content update - How to add an event handler using code (user story 1878475) #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
Contributor
|
Thanks! I'll review this today. |
adegeo
requested changes
Jan 28, 2022
Contributor
adegeo
left a comment
adegeo
left a comment
There was a problem hiding this comment.
Looks great. I've left you some comments to consider.
Thanks!!
dotnet-desktop-guide/net/wpf/events/how-to-add-an-event-handler-using-code.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/wpf/events/how-to-add-an-event-handler-using-code.md
Outdated
Show resolved
Hide resolved
dotnet-desktop-guide/net/wpf/events/how-to-add-an-event-handler-using-code.md
Show resolved
Hide resolved
...ide/net/wpf/events/snippets/how-to-add-an-event-handler-using-code/csharp/MainWindow.xaml.cs
Outdated
Show resolved
Hide resolved
…r-using-code.md Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
…r-using-code.md Co-authored-by: Andy (Steve) De George <67293991+adegeo@users.noreply.github.com>
ghost
marked this pull request as draft
Author
|
@adegeo thanks for your comments - this article is ready for a second review. Since the main feature of routed events is element traversal, I've modified the example to exclude a simple example of that. |
ghost
marked this pull request as ready for review
adegeo
reviewed
Feb 1, 2022
dotnet-desktop-guide/net/wpf/events/how-to-add-an-event-handler-using-code.md
Show resolved
Hide resolved
adegeo
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@adegeo, this PR is ready for your review.
Internal preview link