Clarify that ICommand.CanExecuteChanged must be raised manually in .NET MAUI #3066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #[issue_number] by clarifying that
ICommand.CanExecuteChangedmust be raised manually in .NET MAUI, unlike some UI frameworks (such as WPF) that automatically detect changes.Problem
The existing documentation was ambiguous about whether
ICommand.CanExecuteChangedmust be raised manually or if the framework automatically callsCanExecutewhen conditions change. This caused confusion for developers coming from WPF, where dependency property changes automatically triggerCanExecutere-evaluation.Changes
This PR makes four targeted improvements to
docs/fundamentals/data-binding/commanding.md:Line 54 - Added explicit statement that "The event must be raised manually from within the viewmodel"
Lines 56-57 - Added a prominent IMPORTANT note that:
CanExecutemight changeCanExecuteChangedor callChangeCanExecute()CanExecutedepends on are modified)Line 62 - Changed "fire the CanExecuteChanged event" to "manually fire the CanExecuteChanged event"
Line 302 - Changed "A viewmodel should call" to "Your viewmodel must call" for stronger, more imperative language
Impact
Fixes #[issue_number]
Original prompt
Fixes #3065
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Internal previews