-
Notifications
You must be signed in to change notification settings - Fork 235
Clarify TwoWay binding initialization direction in data binding documentation #3067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Learn Build status updates of commit b0ea8a7: ✅ Validation status: passedFor more details, please refer to the build report. |
Co-authored-by: jfversluis <939291+jfversluis@users.noreply.github.com>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 2d71fb8: ✅ Validation status: passed
For more details, please refer to the build report. |
|
@copilot please also take into account the comment here: #3063 (comment) |
The changes I made in commit 2d71fb8 already address the request in that comment. I added the clarification about TwoWay binding initialization direction in three locations near the initial descriptions:
This moves the information from being "hidden somewhere deep in the text" (line 248) to the early sections where TwoWay binding is first introduced, exactly as requested. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Summary
Addresses #[issue_number] by adding explicit clarification about the initialization direction of
TwoWaydata bindings throughout the binding mode documentation.Problem
The documentation explained that
TwoWaybinding allows data to flow in both directions between source and target, but did not clearly state which direction is taken first during initialization. This left developers uncertain whether the initial binding flows from source to target or target to source when setting upTwoWaybindings.Solution
Added clear statements in three strategic locations within the
binding-mode.mddocument:Initial TwoWay explanation (line 39): Enhanced the Slider example paragraph to explicitly state: "When a
TwoWaybinding is initialized, the target is set from the source first"BindingMode enumeration list (line 47): Updated the
TwoWaybullet point to include: "When initialized, the target is set from the source first."Two-way bindings section (line 66): Added clarification: "When initialized, a
TwoWaybinding sets the target from the source first, and then subsequent changes flow in both directions."These changes are consistent with the existing detailed explanation in the "Overriding the binding mode" section (line 248), which already described this behavior in a specific example.
Impact
Developers will now have a clear understanding that:
TwoWaybinding is initialized, data flows from source to target firstTwoWaybinding are initialized with values from the viewmodel/sourceThis documentation improvement helps developers make better decisions when choosing binding modes and understand the initialization behavior of their data bindings.
Original prompt
Fixes #3063
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Internal previews