20). Add topic files 51 to 54 #17732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshkramer
force-pushed
the
br20-add-topic-files-51-to-54
branch
from
e6dd8f2 to
c626ed3
Compare
mairaw
added
the
vendor-project
BillWagner
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
This LGTM @jameshkramer
I'll wait to 
until @mairaw has a chance to review.
|
@jameshkramer can you review the merge conflicts here? |
|
I fixed the merge conflicts. Thanks for reviewing so quickly! |
|
Is there a reason why this hasn't been merged? |
|
I haven’t had a chance to review yet. Will do it tomorrow |
|
@mairaw, sorry, I thought your merge indicated you had looked at it. |
mairaw
requested changes
Apr 9, 2020
jameshkramer
force-pushed
the
br20-add-topic-files-51-to-54
branch
from
1fe3570 to
3f20657
Compare
|
Maira, you were right - I didn't do that work. Sorry for the bother. I think it's fixed now. |
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
|
Maira, thanks for the review. I wrote the intro you requested. I'll be more careful in the future when I copy links from articles (to be sure all the need link text is there). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mairaw @BillWagner
This PR is for user story #1576037.
It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. There are also fixes to two past articles.
Please merge #17688 before merging this.
cc: @tfosmark @marteeleigh
Contributes to #4728