Skip to content

Conversation

jameshkramer
Copy link
Contributor

@jameshkramer jameshkramer commented Apr 14, 2020

This PR is for user story #1576037.

It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries.

Please merge #17732 and #17772 before merging this.

cc: @tfosmark @marteeleigh

Contributes to #4728

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 14, 2020
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Apr 15, 2020
@BillWagner
Copy link
Member

@jameshkramer This currently has merge conflicts. Do you want me to review now, or wait until those are resolved?

@jameshkramer
Copy link
Contributor Author

I resolved the conflicts, but we will probably get more when the prior PR, #17772, is merged.

We get these merge conflicts because I always add redirections to the redirections file from linq-to-xml, rather than to the one in my most recent PR. We get the conflicts when there is more than one unmerged PR. We could reduce conflicts if I always built the redirections file from the one in the prior PR, even if the PR has not yet been merged.

What do you think?

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine we'll have a few merge conflicts to deal with after the other PR is merged. But left a few comments for now.

## See also

- <xref:System.Linq.Enumerable.Select%2A>
- [Projections and Transformations (LINQ to XML) (Visual Basic)](../../visual-basic/programming-guide/concepts/linq/projections-and-transformations-linq-to-xml.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this article would be moved to this folder too, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just becomes a parent node. You make a good point, though. That does happen in this part of the project, and I could deal with it now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you. We can merge as-is and then once you redirect, you'd have to change these links.

Co-Authored-By: Maira Wenzel <mairaw@microsoft.com>
@mairaw
Copy link
Contributor

mairaw commented Apr 15, 2020

Some merge conflicts to resolve now 😄

@mairaw mairaw merged commit bd77fd1 into dotnet:linq-to-xml Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants