Skip to content

Conversation

jameshkramer
Copy link
Contributor

This PR is for user story #1576037.

It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. It also fixes toc.yml.

Please merge #17846, #17892, and #17928 before merging this.

cc: @mairaw @tfosmark @marteeleigh

Contributes to #4728

@dotnet-bot dotnet-bot added this to the April 2020 milestone Apr 22, 2020
@jameshkramer jameshkramer force-pushed the br25-add-topic-files-71-to-74 branch from d6e1ba4 to 0fd630b Compare April 23, 2020 00:08
@mairaw mairaw added the vendor-project Indicates the issue/pr is related to a vendor project. label Apr 26, 2020
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments to be addressed before merging.


There are some caveats regarding streaming transformations. A streaming transformation is best applied in situations where you can process the entire file once, and if you can process the lines in the order that they occur in the source document. If you have to process the file more than once, or if you have to sort the lines before you can process them, you will lose many of the benefits of using a streaming technique.
You can use an extension method that releases a line at a time to stream a text file for processing. This technique reduces memory requirements compared to techniques which load the entire file and then process it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillWagner do you wanna review the text changes here?

@mairaw
Copy link
Contributor

mairaw commented Apr 30, 2020

@jameshkramer ping me when comments and merge conflicts are resolved. Thanks!

@mairaw
Copy link
Contributor

mairaw commented May 1, 2020

@jameshkramer do you wanna resolve the merge conflicts here?

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @BillWagner do you want to take a look at the changes he's made? Thanks.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I'll :shipit: now.

@BillWagner BillWagner merged commit c951ecf into dotnet:linq-to-xml May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vendor-project Indicates the issue/pr is related to a vendor project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants