-
Notifications
You must be signed in to change notification settings - Fork 6k
25). Add topic files 71 to 74 #18022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
25). Add topic files 71 to 74 #18022
Conversation
d6e1ba4
to
0fd630b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left some comments to be addressed before merging.
|
||
There are some caveats regarding streaming transformations. A streaming transformation is best applied in situations where you can process the entire file once, and if you can process the lines in the order that they occur in the source document. If you have to process the file more than once, or if you have to sort the lines before you can process them, you will lose many of the benefits of using a streaming technique. | ||
You can use an extension method that releases a line at a time to stream a text file for processing. This technique reduces memory requirements compared to techniques which load the entire file and then process it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillWagner do you wanna review the text changes here?
@jameshkramer ping me when comments and merge conflicts are resolved. Thanks! |
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
Co-authored-by: Maira Wenzel <mairaw@microsoft.com>
…-streaming-transformations-text-xml.md
@jameshkramer do you wanna resolve the merge conflicts here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @BillWagner do you want to take a look at the changes he's made? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I'll now.
This PR is for user story #1576037.
It adds four article files, makes corresponding deletions from the C# and VB folders, and adds redirection entries. It also fixes toc.yml.
Please merge #17846, #17892, and #17928 before merging this.
cc: @mairaw @tfosmark @marteeleigh
Contributes to #4728