Skip to content

Conversation

@v-mepa
Copy link
Contributor

@v-mepa v-mepa commented Nov 4, 2020

fyi @mairaw

Add_try_dotnet_to_batch_25a

S No URL Batch No Comments
1 https://docs.microsoft.com/en-us/dotnet/api/system.convert.toint32 Batch 25 Not for ToInt32(Object, IFormatProvider) and ToInt32(Object) samples - culture dependent. Fix sample output of ToInt32(Char).
2 https://docs.microsoft.com/en-us/dotnet/api/system.array.setvalue Batch 25 Duplicate samples for all overloads? Potentially move it to the MemberGroup.
3 https://docs.microsoft.com/en-us/dotnet/api/system.attribute.getcustomattribute Batch 25  
4 https://docs.microsoft.com/en-us/dotnet/api/system.array.convertall Batch 25  
5 https://docs.microsoft.com/en-us/dotnet/api/system.objectdisposedexception Batch 25 Only first example, second one throws exception
6 https://docs.microsoft.com/en-us/dotnet/api/system.timespan.fromseconds Batch 25 Only first example. Remaining sample is not runnable.
7 https://docs.microsoft.com/en-us/dotnet/api/system.enum.getnames Batch 25  
8 https://docs.microsoft.com/en-us/dotnet/api/system.uint32.maxvalue Batch 25  
9 https://docs.microsoft.com/en-us/dotnet/api/system.linq.queryable.asqueryable Batch 25  
10 https://docs.microsoft.com/en-us/dotnet/api/system.datetime.addseconds Batch 25  

@opbld34
Copy link

opbld34 commented Nov 4, 2020

Docs Build status updates of commit 3804ed2:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System/Convert.xml ⚠️Warning View Details
xml/System.Linq/Queryable.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/ObjectDisposedException.xml ✅Succeeded View
xml/System/TimeSpan.xml ✅Succeeded View
xml/System/UInt32.xml ✅Succeeded View

xml/System/Convert.xml

  • Line 0, Column 0: [Warning-unknown-language-code] Unrecognized language value '.cs#12' in code snippet 'Snippet12' in file '~/samples/snippets/csharp/VS_Snippets_CLR_System/system.convert.toint32/cs/toint32_1.cs#12'. Your code snippet might not render correctly. If this is the case, you can request a new value or use range instead.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mairaw mairaw self-requested a review November 4, 2020 22:38
@mairaw mairaw added the 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs label Nov 4, 2020
@opbld30
Copy link

opbld30 commented Nov 4, 2020

Docs Build status updates of commit 0ecf18f:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Linq/Queryable.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View
xml/System/Convert.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/ObjectDisposedException.xml ✅Succeeded View
xml/System/TimeSpan.xml ✅Succeeded View
xml/System/UInt32.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mairaw
Copy link
Contributor

mairaw commented Nov 8, 2020

Missing running sample for Convert.ToInt32(Int16), Convert.ToInt32(Double), Convert.ToInt32(Decimal), Convert.ToInt32(Byte), Convert.ToInt32(Boolean) at https://review.docs.microsoft.com/en-us/dotnet/api/system.convert.toint32?branch=pr-en-us-5085&view=netcore-3.1

@mairaw
Copy link
Contributor

mairaw commented Nov 8, 2020

Missed removing the sample from Array.SetValue(Object, Int32, Int32, Int32)
at https://review.docs.microsoft.com/en-us/dotnet/api/system.array.setvalue?branch=pr-en-us-5085

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Left a couple of comments.

[!code-vb[IsDefined#1](~/samples/snippets/visualbasic/VS_Snippets_CLR/IsDefined/VB/id1.vb#1)]
 
:::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/IsDefined/CPP/isdefined.cpp" id="Snippet1":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" interactive="try-dotnet" id="Snippet1":::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" interactive="try-dotnet" id="Snippet1":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" id="Snippet1":::

[!code-vb[IsDefined#1](~/samples/snippets/visualbasic/VS_Snippets_CLR/IsDefined/VB/id1.vb#1)]
 
:::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/IsDefined/CPP/isdefined.cpp" id="Snippet1":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" interactive="try-dotnet" id="Snippet1":::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" interactive="try-dotnet" id="Snippet1":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" id="Snippet1":::

[!code-vb[IsDefined#2](~/samples/snippets/visualbasic/VS_Snippets_CLR/IsDefined/VB/id2.vb#2)]
 
:::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/IsDefined/CPP/isdefined.cpp" id="Snippet2":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" interactive="try-dotnet" id="Snippet2":::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" interactive="try-dotnet" id="Snippet2":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" id="Snippet2":::

[!code-vb[IsDefined#2](~/samples/snippets/visualbasic/VS_Snippets_CLR/IsDefined/VB/id2.vb#2)]
 
:::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/IsDefined/CPP/isdefined.cpp" id="Snippet2":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" interactive="try-dotnet" id="Snippet2":::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" interactive="try-dotnet" id="Snippet2":::
:::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" id="Snippet2":::

@opbld34
Copy link

opbld34 commented Nov 9, 2020

Docs Build status updates of commit 3ba3af8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Linq/Queryable.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View
xml/System/Convert.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/ObjectDisposedException.xml ✅Succeeded View
xml/System/TimeSpan.xml ✅Succeeded View
xml/System/UInt32.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Nov 9, 2020

Docs Build status updates of commit e1fa683:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Linq/Queryable.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View
xml/System/Convert.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/ObjectDisposedException.xml ✅Succeeded View
xml/System/TimeSpan.xml ✅Succeeded View
xml/System/UInt32.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mairaw
Copy link
Contributor

mairaw commented Nov 30, 2020

Convert.ToInt32(Char) is still missing

@opbld33
Copy link

opbld33 commented Nov 30, 2020

Docs Build status updates of commit 78c8432:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Linq/Queryable.xml ✅Succeeded View
xml/System/Array.xml ✅Succeeded View
xml/System/Attribute.xml ✅Succeeded View
xml/System/Convert.xml ✅Succeeded View
xml/System/DateTime.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/ObjectDisposedException.xml ✅Succeeded View
xml/System/TimeSpan.xml ✅Succeeded View
xml/System/UInt32.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mairaw mairaw merged commit a2f71af into dotnet:master Nov 30, 2020
@v-mepa v-mepa deleted the add_try_dotnet_to_batch_25a branch November 30, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Runtime 👩‍💻 .NET Interactive These issues relate to using .NET Interactive in docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants