-
Notifications
You must be signed in to change notification settings - Fork 1.7k
.NET Interactive: add_try_dotnet_to_batch_25a #5085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Docs Build status updates of commit 3804ed2:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| xml/System/Convert.xml | View | Details | |
| xml/System.Linq/Queryable.xml | ✅Succeeded | View | |
| xml/System/Array.xml | ✅Succeeded | View | |
| xml/System/Attribute.xml | ✅Succeeded | View | |
| xml/System/DateTime.xml | ✅Succeeded | View | |
| xml/System/Enum.xml | ✅Succeeded | View | |
| xml/System/ObjectDisposedException.xml | ✅Succeeded | View | |
| xml/System/TimeSpan.xml | ✅Succeeded | View | |
| xml/System/UInt32.xml | ✅Succeeded | View |
xml/System/Convert.xml
- Line 0, Column 0: [Warning-unknown-language-code]
Unrecognized language value '.cs#12' in code snippet 'Snippet12' in file '~/samples/snippets/csharp/VS_Snippets_CLR_System/system.convert.toint32/cs/toint32_1.cs#12'. Your code snippet might not render correctly. If this is the case, you can request a new value or use range instead.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching in the Docs contributor and Admin Guide
- See the frequently asked questions
- Post your question in the Docs support channel
|
Docs Build status updates of commit 0ecf18f: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Missing running sample for Convert.ToInt32(Int16), Convert.ToInt32(Double), Convert.ToInt32(Decimal), Convert.ToInt32(Byte), Convert.ToInt32(Boolean) at https://review.docs.microsoft.com/en-us/dotnet/api/system.convert.toint32?branch=pr-en-us-5085&view=netcore-3.1 |
|
Missed removing the sample from Array.SetValue(Object, Int32, Int32, Int32) |
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Left a couple of comments.
xml/System/Attribute.xml
Outdated
| [!code-vb[IsDefined#1](~/samples/snippets/visualbasic/VS_Snippets_CLR/IsDefined/VB/id1.vb#1)] | ||
| :::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/IsDefined/CPP/isdefined.cpp" id="Snippet1"::: | ||
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" interactive="try-dotnet" id="Snippet1"::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" interactive="try-dotnet" id="Snippet1"::: | |
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" id="Snippet1"::: |
xml/System/Attribute.xml
Outdated
| [!code-vb[IsDefined#1](~/samples/snippets/visualbasic/VS_Snippets_CLR/IsDefined/VB/id1.vb#1)] | ||
| :::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/IsDefined/CPP/isdefined.cpp" id="Snippet1"::: | ||
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" interactive="try-dotnet" id="Snippet1"::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" interactive="try-dotnet" id="Snippet1"::: | |
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id1.cs" id="Snippet1"::: |
xml/System/Attribute.xml
Outdated
| [!code-vb[IsDefined#2](~/samples/snippets/visualbasic/VS_Snippets_CLR/IsDefined/VB/id2.vb#2)] | ||
| :::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/IsDefined/CPP/isdefined.cpp" id="Snippet2"::: | ||
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" interactive="try-dotnet" id="Snippet2"::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" interactive="try-dotnet" id="Snippet2"::: | |
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" id="Snippet2"::: |
xml/System/Attribute.xml
Outdated
| [!code-vb[IsDefined#2](~/samples/snippets/visualbasic/VS_Snippets_CLR/IsDefined/VB/id2.vb#2)] | ||
| :::code language="cpp" source="~/samples/snippets/cpp/VS_Snippets_CLR/IsDefined/CPP/isdefined.cpp" id="Snippet2"::: | ||
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" interactive="try-dotnet" id="Snippet2"::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" interactive="try-dotnet" id="Snippet2"::: | |
| :::code language="csharp" source="~/samples/snippets/csharp/VS_Snippets_CLR/IsDefined/CS/id2.cs" id="Snippet2"::: |
|
Docs Build status updates of commit 3ba3af8: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit e1fa683: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Convert.ToInt32(Char) is still missing |
|
Docs Build status updates of commit 78c8432: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
mairaw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
fyi @mairaw
Add_try_dotnet_to_batch_25a