Update KubernetesEntitySyntaxReceiver to support reading entity metadata from const variables #979
+97
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata from const variables
… to eliminate the handling for different expression types
Collaborator
|
This should also be fixed by #980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am writing an operator the provisions some 3rd-party APIs, which provides their own custom CRDs. I was using KubernetesCRDModelGen to generate the models given the CRD specs. It generates
constvariables with theKubernetesEntitymetadata, which is a pattern similar to what the kubernetes client does. This PR adds support for reading the metadata from thoseconstvariables. This also fixes a typo in the attribute name used to discoverPluralName.