Marking for re-triage. I don't think we should change this.

First, it is a public interface. It is documented as for use by providers and extensions, but not as internal.

But even without that, the current API is shown below. Notice that it is a helper class with pairs of methods for common tasks. Each pair has a string overload and a StringBuilder overload. In our providers we don't happen to use the StringBuilder overload of one of these methods. But that doesn't mean it isn't already used by other providers or would be useful to other providers and extensions. Therefore, I think we should keep it.

Since we have no tests for it, maybe this item should be about writing some tests?

public interface ISqlGenerationHelper
{
    string StatementTerminator { get; }
    string BatchTerminator { get; }
    string GenerateParameterName([NotNull] string name);
    void GenerateParameterName([NotNull] StringBuilder builder, [NotNull] string name);
    string GenerateLiteral([CanBeNull] object value, [CanBeNull] RelationalTypeMapping typeMapping = null);
    void GenerateLiteral([NotNull] StringBuilder builder, [CanBeNull] object value, [CanBeNull] RelationalTypeMapping typeMapping = null);
    string EscapeLiteral([NotNull] string literal);
    void EscapeLiteral([NotNull] StringBuilder builder, [NotNull] string literal);
    string EscapeIdentifier([NotNull] string identifier);
    void EscapeIdentifier([NotNull] StringBuilder builder, [NotNull] string identifier);
    string DelimitIdentifier([NotNull] string identifier);
    void DelimitIdentifier([NotNull] StringBuilder builder, [NotNull] string identifier);
    string DelimitIdentifier([NotNull] string name, [CanBeNull] string schema);
    void DelimitIdentifier([NotNull] StringBuilder builder, [NotNull] string name, [CanBeNull] string schema);
}

Unused method on ISqlGenerationHelper #5847

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions