Remove internal types from Logging and Abstractions

src/Logging/Logging.Abstractions/src/Internal/FormattedLogValues.cs → src/Logging/Logging.Abstractions/src/FormattedLogValues.cs

@@ -7,13 +7,13 @@
 using System.Collections.Generic;
 using System.Threading;
 
-namespace Microsoft.Extensions.Logging.Internal
+namespace Microsoft.Extensions.Logging
 {
     /// <summary>
     /// LogValues to enable formatting options supported by <see cref="M:string.Format"/>.
     /// This also enables using {NamedformatItem} in the format string.
     /// </summary>
-    public readonly struct FormattedLogValues : IReadOnlyList<KeyValuePair<string, object>>
+    internal readonly struct FormattedLogValues : IReadOnlyList<KeyValuePair<string, object>>
     {
         internal const int MaxCachedFormatters = 1024;
         private const string NullFormat = "[null]";

src/Logging/Logging.Abstractions/src/ILoggerOfT.cs → src/Logging/Logging.Abstractions/src/ILoggerT.cs

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
-
 namespace Microsoft.Extensions.Logging
 {
     /// <summary>

src/Logging/Logging.Abstractions/src/Internal/LogValuesFormatter.cs → src/Logging/Logging.Abstractions/src/LogValuesFormatter.cs

@@ -8,12 +8,12 @@
 using System.Globalization;
 using System.Text;
 
-namespace Microsoft.Extensions.Logging.Internal
+namespace Microsoft.Extensions.Logging
 {
     /// <summary>
     /// Formatter to convert the named format items like {NamedformatItem} to <see cref="M:string.Format"/> format.
     /// </summary>
-    public class LogValuesFormatter
+    internal class LogValuesFormatter
     {
         private const string NullValue = "(null)";
         private static readonly object[] EmptyArray = new object[0];
@@ -34,16 +34,16 @@ public LogValuesFormatter(string format)
                 var openBraceIndex = FindBraceIndex(format, '{', scanIndex, endIndex);
                 var closeBraceIndex = FindBraceIndex(format, '}', openBraceIndex, endIndex);
 
-                // Format item syntax : { index[,alignment][ :formatString] }.
-                var formatDelimiterIndex = FindIndexOfAny(format, FormatDelimiters, openBraceIndex, closeBraceIndex);
-
                 if (closeBraceIndex == endIndex)
                 {
                     sb.Append(format, scanIndex, endIndex - scanIndex);
                     scanIndex = endIndex;
                 }
                 else
                 {
+                    // Format item syntax : { index[,alignment][ :formatString] }.
+                    var formatDelimiterIndex = FindIndexOfAny(format, FormatDelimiters, openBraceIndex, closeBraceIndex);
+
                     sb.Append(format, scanIndex, openBraceIndex - scanIndex + 1);
                     sb.Append(_valueNames.Count.ToString(CultureInfo.InvariantCulture));
                     _valueNames.Add(format.Substring(openBraceIndex + 1, formatDelimiterIndex - openBraceIndex - 1));

src/Logging/Logging.Abstractions/src/LoggerExtensions.cs

@@ -2,9 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
-using System.Collections.Generic;
-using System.Globalization;
-using Microsoft.Extensions.Logging.Internal;
 
 namespace Microsoft.Extensions.Logging
 {

src/Logging/Logging.Abstractions/src/LoggerExternalScopeProvider.cs

@@ -2,11 +2,7 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Runtime.InteropServices;
 using System.Threading;
-using Microsoft.Extensions.Logging;
 
 namespace Microsoft.Extensions.Logging
 {
@@ -73,4 +69,4 @@ public void Dispose()
             }
         }
     }
-}
+}

src/Logging/Logging.Abstractions/src/LoggerFactoryExtensions.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
-using Microsoft.Extensions.Logging.Abstractions.Internal;
 
 namespace Microsoft.Extensions.Logging
 {
@@ -44,4 +43,4 @@ public static ILogger CreateLogger(this ILoggerFactory factory, Type type)
             return factory.CreateLogger(TypeNameHelper.GetTypeDisplayName(type));
         }
     }
-}
+}

src/Logging/Logging.Abstractions/src/LoggerMessage.cs

@@ -1,11 +1,10 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
 using System.Collections;
 using System.Collections.Generic;
 using Microsoft.Extensions.Logging.Abstractions;
-using Microsoft.Extensions.Logging.Internal;
 
 namespace Microsoft.Extensions.Logging
 {

src/Logging/Logging.Abstractions/src/LoggerOfT.cs → src/Logging/Logging.Abstractions/src/LoggerT.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
-using Microsoft.Extensions.Logging.Abstractions.Internal;
 
 namespace Microsoft.Extensions.Logging
 {
@@ -44,4 +43,4 @@ void ILogger.Log<TState>(LogLevel logLevel, EventId eventId, TState state, Excep
             _logger.Log(logLevel, eventId, state, exception, formatter);
         }
     }
-}
+}

src/Logging/Logging.Abstractions/src/Internal/TypeNameHelper.cs → src/Logging/Logging.Abstractions/src/TypeNameHelper.cs

@@ -5,9 +5,9 @@
 using System.Collections.Generic;
 using System.Reflection;
 
-namespace Microsoft.Extensions.Logging.Abstractions.Internal
+namespace Microsoft.Extensions.Logging
 {
-    public class TypeNameHelper
+    internal class TypeNameHelper
     {
         private static readonly Dictionary<Type, string> _builtInTypeNames = new Dictionary<Type, string>
             {
@@ -78,4 +78,4 @@ public static string GetTypeDisplayName(Type type)
             }
         }
     }
-}
+}

src/Logging/Logging.Analyzers/src/LogFormatAnalyzer.cs

@@ -9,7 +9,6 @@
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.Diagnostics;
-using Microsoft.Extensions.Logging.Internal;
 
 namespace Microsoft.Extensions.Logging.Analyzers
 {

src/Logging/Logging.Analyzers/src/Microsoft.Extensions.Logging.Analyzers.csproj

@@ -14,7 +14,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <Compile Include="..\..\Logging.Abstractions\src\Internal\LogValuesFormatter.cs" />
+    <Compile Include="..\..\Logging.Abstractions\src\LogValuesFormatter.cs" />
   </ItemGroup>
 
   <ItemGroup>

src/Logging/Logging.Analyzers/test/LoggingDiagnosticRunner.cs

@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Analyzer.Testing;
 using Microsoft.CodeAnalysis;

src/Logging/Logging.AzureAppServices/src/AzureAppServicesLoggerFactoryExtensions.cs

@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;

src/Logging/Logging.Configuration/src/LoggerProviderConfigurationFactory.cs

@@ -1,9 +1,8 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
 using System.Collections.Generic;
-using System.Reflection;
 using Microsoft.Extensions.Configuration;
 
 namespace Microsoft.Extensions.Logging.Configuration
@@ -41,4 +40,4 @@ public IConfiguration GetConfiguration(Type providerType)
             return configurationBuilder.Build();
         }
     }
-}
+}

src/Logging/Logging.Console/src/ConsoleLogger.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Text;
-using Microsoft.Extensions.Logging.Abstractions.Internal;
 
 namespace Microsoft.Extensions.Logging.Console
 {

src/Logging/Logging.Console/src/ConsoleLoggerProvider.cs

@@ -4,7 +4,6 @@
 using System;
 using System.Collections.Concurrent;
 using System.Runtime.InteropServices;
-using Microsoft.Extensions.Logging.Abstractions;
 using Microsoft.Extensions.Options;
 
 namespace Microsoft.Extensions.Logging.Console

src/Logging/Logging.Debug/src/DebugLoggerFactoryExtensions.cs

@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.DependencyInjection.Extensions;
 using Microsoft.Extensions.Logging.Debug;

src/Logging/Logging.Testing/src/RetryContext.cs

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
-
 namespace Microsoft.Extensions.Logging.Testing
 {
     public class RetryContext
@@ -15,4 +13,4 @@ public class RetryContext
 
         internal int CurrentIteration { get; set; }
     }
-}
+}

src/Logging/Logging.Testing/src/TestLoggerFactory.cs

@@ -1,8 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
-
 namespace Microsoft.Extensions.Logging.Testing
 {
     public class TestLoggerFactory : ILoggerFactory
@@ -29,4 +27,4 @@ public void Dispose()
         {
         }
     }
-}
+}

src/Logging/Logging.Testing/src/Xunit/LoggedTestRunner.cs

@@ -1,4 +1,4 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
@@ -9,7 +9,6 @@
 using System.Threading;
 using System.Threading.Tasks;
 using Microsoft.AspNetCore.Testing.xunit;
-using Microsoft.Extensions.Logging.Testing;
 using Xunit.Abstractions;
 using Xunit.Sdk;
 

src/Logging/Logging.Testing/test/XunitLoggerProviderTest.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Text.RegularExpressions;
-using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging.Test;
 using Xunit;
 

src/Logging/Logging/src/Logger.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using Microsoft.Extensions.Logging.Abstractions.Internal;
 
 namespace Microsoft.Extensions.Logging
 {
@@ -195,4 +194,4 @@ public void Dispose()
             }
         }
     }
-}
+}

src/Logging/Logging/src/LoggerFactory.cs

@@ -1,10 +1,9 @@
-// Copyright (c) .NET Foundation. All rights reserved.
+// Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using System.Runtime.InteropServices;
 using Microsoft.Extensions.Options;
 
 namespace Microsoft.Extensions.Logging

src/Logging/test/Console/ConsoleSink.cs

@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
 using System.Collections.Generic;
 
 namespace Microsoft.Extensions.Logging.Test.Console
@@ -15,4 +14,4 @@ public void Write(ConsoleContext context)
             Writes.Add(context);
         }
     }
-}
+}

src/Logging/test/DebugLoggerTest.cs

@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using Microsoft.Extensions.Logging.Debug;
 using Microsoft.Extensions.Logging.Test;
 using Xunit;
 

src/Logging/test/FormattedLogValuesTest.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Linq;
-using Microsoft.Extensions.Logging.Internal;
 using Xunit;
 
 namespace Microsoft.Extensions.Logging.Test

src/Logging/test/LoggerExtensionsTest.cs

@@ -5,7 +5,6 @@
 using System.Collections;
 using System.Collections.Generic;
 using System.Linq;
-using Microsoft.Extensions.Logging.Internal;
 using Microsoft.Extensions.Logging.Testing;
 using Xunit;
 

src/Logging/test/LoggerFactoryTest.cs

@@ -3,7 +3,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Text;
 using Moq;
 using Xunit;
 

src/Logging/test/TraceSourceLoggerTest.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System.Diagnostics;
-using Microsoft.Extensions.DependencyInjection;
 using Xunit;
 
 namespace Microsoft.Extensions.Logging.Test

src/Logging/test/TraceSourceScopeTest.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
 using System.Diagnostics;
-using Microsoft.Extensions.DependencyInjection;
 using Xunit;
 
 namespace Microsoft.Extensions.Logging.Test

src/Shared/src/BenchmarkRunner/DefaultCoreValidationConfig.cs

@@ -1,11 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
 
-using System;
-using System.Linq;
-using System.Reflection;
-using BenchmarkDotNet.Attributes;
-using BenchmarkDotNet.Running;
 using BenchmarkDotNet.Configs;
 using BenchmarkDotNet.Jobs;
 using BenchmarkDotNet.Loggers;