Skip to content

Fix 14745 - Reactivate byref tests #14766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 22, 2023
Merged

Fix 14745 - Reactivate byref tests #14766

merged 7 commits into from
Feb 22, 2023

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Feb 17, 2023

This PR - depends on the IsReadOnlyAttribute pr. it won't be merged until that one is merged.

  1. Reactive Byref tests
  2. Move them from cambridge suite to the ComponentTests suite
  3. Add a netstandard2.0 version with il generation

@KevinRansom KevinRansom requested a review from a team as a code owner February 17, 2023 09:22
@KevinRansom KevinRansom reopened this Feb 18, 2023
@KevinRansom KevinRansom reopened this Feb 18, 2023
@KevinRansom KevinRansom merged commit f5543c9 into dotnet:main Feb 22, 2023
@KevinRansom KevinRansom mentioned this pull request Feb 22, 2023
Closed
@allisonchou allisonchou mentioned this pull request Feb 27, 2023
Closed
@KevinRansom KevinRansom deleted the Fix14745 branch April 29, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@0101 0101 0101 approved these changes

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release/17.6

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KevinRansom @0101 @psfinaki @vzarytovskii