Skip to content

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Feb 19, 2023

Okay this failed for a couple of different reasons.

  1. #r "nuget : executes in a different location from the tests and so had additional unintentional sources specified. So job 1 was to disable that. This was done by generating a Nuget.config alongside the packagemanagement project with inherited sources cleared.
  2. One of the failing tests, wasn't testing anything useful. TBH ... wasn't doing what I believe the test author was trying to achieve. For this one I cleaned up the test a bit, and disabled with a new issue the dodgiest part of the test. It will need product work to do what was intended.
  3. Now that we are no longer relying on reaching nuget.org via a kind of back door, We had to add FSharp.Data, 3.3.3 to the dotnet-public mirror.

@KevinRansom KevinRansom requested a review from a team as a code owner February 19, 2023 21:27
@KevinRansom KevinRansom reopened this Feb 20, 2023
@KevinRansom KevinRansom force-pushed the fixdapperonmacos branch 7 times, most recently from 1f5299a to aecc65b Compare February 21, 2023 19:43
@KevinRansom KevinRansom reopened this Feb 21, 2023
@KevinRansom KevinRansom force-pushed the fixdapperonmacos branch 2 times, most recently from b0ff392 to 75b25a9 Compare February 22, 2023 19:42
@KevinRansom KevinRansom reopened this Feb 23, 2023
@KevinRansom KevinRansom force-pushed the fixdapperonmacos branch 2 times, most recently from be5dd05 to 769c23f Compare February 25, 2023 00:16
@KevinRansom KevinRansom reopened this Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants