Skip to content

Simplified some tests a bit #14787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Simplified some tests a bit #14787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40ce184
Simplified some tests a bit
psfinaki Feb 22, 2023
c262ca3
Merge branch 'main' into fantomas-3
KevinRansom Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .fantomasignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ src/Compiler/TypedTree/TypedTreeOps.fs
src/Compiler/TypedTree/TypedTreePickle.fs
src/Compiler/TypedTree/TypeProviders.fs

# https://github.com/fsprojects/fantomas/issues/2779
vsintegration/tests/FSharp.Editor.Tests/QuickInfoProviderTests.fs

# Explicitly unformatted file that needs more care to get it to format well

src/Compiler/SyntaxTree/LexFilter.fs
Expand Down
136 changes: 68 additions & 68 deletions vsintegration/tests/FSharp.Editor.Tests/QuickInfoProviderTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,97 +193,97 @@ let res8 = abs 5.0<kg>
let testCases =

[
("GroupBy",
Some
"(extension) System.Collections.Generic.IEnumerable.GroupBy<'TSource,'TKey>(keySelector: System.Func<'TSource,'TKey>) : System.Collections.Generic.IEnumerable<IGrouping<'TKey,'TSource>>
"GroupBy",
Some
"(extension) System.Collections.Generic.IEnumerable.GroupBy<'TSource,'TKey>(keySelector: System.Func<'TSource,'TKey>) : System.Collections.Generic.IEnumerable<IGrouping<'TKey,'TSource>>
'TSource is int * string
'TKey is int");
("Sort",
Some
"System.Array.Sort<'T>(array: 'T array) : unit
'T is int");
("let test4 x = C().FSharpGenericMethodExplitTypeParams",
Some
"member C.FSharpGenericMethodExplitTypeParams: a: 'T0 * y: 'T0 -> 'T0 * 'T0
'T is 'a list");
("let test5<'U> (x: 'U) = C().FSharpGenericMethodExplitTypeParams",
Some
"member C.FSharpGenericMethodExplitTypeParams: a: 'T0 * y: 'T0 -> 'T0 * 'T0
'T is 'U list");
("let test6 = C().FSharpGenericMethodExplitTypeParams",
Some
"member C.FSharpGenericMethodExplitTypeParams: a: 'T0 * y: 'T0 -> 'T0 * 'T0
'T is int");
("let test7 x = C().FSharpGenericMethodInferredTypeParams",
Some
"member C.FSharpGenericMethodInferredTypeParams: a: 'a1 * y: 'b2 -> 'a1 * 'b2
'TKey is int"
"Sort",
Some
"System.Array.Sort<'T>(array: 'T array) : unit
'T is int"
"let test4 x = C().FSharpGenericMethodExplitTypeParams",
Some
"member C.FSharpGenericMethodExplitTypeParams: a: 'T0 * y: 'T0 -> 'T0 * 'T0
'T is 'a list"
"let test5<'U> (x: 'U) = C().FSharpGenericMethodExplitTypeParams",
Some
"member C.FSharpGenericMethodExplitTypeParams: a: 'T0 * y: 'T0 -> 'T0 * 'T0
'T is 'U list"
"let test6 = C().FSharpGenericMethodExplitTypeParams",
Some
"member C.FSharpGenericMethodExplitTypeParams: a: 'T0 * y: 'T0 -> 'T0 * 'T0
'T is int"
"let test7 x = C().FSharpGenericMethodInferredTypeParams",
Some
"member C.FSharpGenericMethodInferredTypeParams: a: 'a1 * y: 'b2 -> 'a1 * 'b2
'a is 'a0 list
'b is 'a0 list");
("let test8 = C().FSharpGenericMethodInferredTypeParams",
Some
"member C.FSharpGenericMethodInferredTypeParams: a: 'a0 * y: 'b1 -> 'a0 * 'b1
'b is 'a0 list"
"let test8 = C().FSharpGenericMethodInferredTypeParams",
Some
"member C.FSharpGenericMethodInferredTypeParams: a: 'a0 * y: 'b1 -> 'a0 * 'b1
'a is int
'b is int");
("let test9<'U> (x: 'U) = C().FSharpGenericMethodInferredTypeParams",
Some
"member C.FSharpGenericMethodInferredTypeParams: a: 'a0 * y: 'b1 -> 'a0 * 'b1
'b is int"
"let test9<'U> (x: 'U) = C().FSharpGenericMethodInferredTypeParams",
Some
"member C.FSharpGenericMethodInferredTypeParams: a: 'a0 * y: 'b1 -> 'a0 * 'b1
'a is 'U list
'b is 'U list");
("let res3 = [1] |>",
Some
"val (|>) : arg: 'T1 -> func: ('T1 -> 'U) -> 'U
'b is 'U list"
"let res3 = [1] |>",
Some
"val (|>) : arg: 'T1 -> func: ('T1 -> 'U) -> 'U
Full name: Microsoft.FSharp.Core.Operators.(|>)
'T1 is int list
'U is int list");
("let res3 = [1] |> List.map id",
Some
"val id: x: 'T -> 'T
'U is int list"
"let res3 = [1] |> List.map id",
Some
"val id: x: 'T -> 'T
Full name: Microsoft.FSharp.Core.Operators.id
'T is int");
("let res4 = (1.0,[1]) ||>",
Some
"val (||>) : arg1: 'T1 * arg2: 'T2 -> func: ('T1 -> 'T2 -> 'U) -> 'U
'T is int"
"let res4 = (1.0,[1]) ||>",
Some
"val (||>) : arg1: 'T1 * arg2: 'T2 -> func: ('T1 -> 'T2 -> 'U) -> 'U
Full name: Microsoft.FSharp.Core.Operators.(||>)
'T1 is float
'T2 is int list
'U is float");
("let res4 = (1.0,[1]) ||> List.fold",
Some
"val fold: folder: ('State -> 'T -> 'State) -> state: 'State -> list: 'T list -> 'State
'U is float"
"let res4 = (1.0,[1]) ||> List.fold",
Some
"val fold: folder: ('State -> 'T -> 'State) -> state: 'State -> list: 'T list -> 'State
Full name: Microsoft.FSharp.Collections.List.fold
'T is int
'State is float");
("let res4 = (1.0,[1]) ||> List.fold (fun s x -> string s +",
Some
"val (+) : x: 'T1 -> y: 'T2 -> 'T3 (requires member (+))
'State is float"
"let res4 = (1.0,[1]) ||> List.fold (fun s x -> string s +",
Some
"val (+) : x: 'T1 -> y: 'T2 -> 'T3 (requires member (+))
Full name: Microsoft.FSharp.Core.Operators.(+)
'T1 is string
'T2 is string
'T3 is float");
("let res5 = 1 +",
Some
"val (+) : x: 'T1 -> y: 'T2 -> 'T3 (requires member (+))
'T3 is float"
"let res5 = 1 +",
Some
"val (+) : x: 'T1 -> y: 'T2 -> 'T3 (requires member (+))
Full name: Microsoft.FSharp.Core.Operators.(+)
'T1 is int
'T2 is int
'T3 is int");
("let res6 = System.DateTime.Now +",
Some
"val (+) : x: 'T1 -> y: 'T2 -> 'T3 (requires member (+))
'T3 is int"
"let res6 = System.DateTime.Now +",
Some
"val (+) : x: 'T1 -> y: 'T2 -> 'T3 (requires member (+))
Full name: Microsoft.FSharp.Core.Operators.(+)
'T1 is System.DateTime
'T2 is System.TimeSpan
'T3 is System.DateTime");
("let res7 = sin",
Some
"val sin: value: 'T -> 'T (requires member Sin)
'T3 is System.DateTime"
"let res7 = sin",
Some
"val sin: value: 'T -> 'T (requires member Sin)
Full name: Microsoft.FSharp.Core.Operators.sin
'T is float");
("let res8 = abs",
Some
"val abs: value: 'T -> 'T (requires member Abs)
'T is float"
"let res8 = abs",
Some
"val abs: value: 'T -> 'T (requires member Abs)
Full name: Microsoft.FSharp.Core.Operators.abs
'T is int");
'T is int"
]

executeQuickInfoTest fileContents testCases