Some fixes and improvements for "go to all" search in Visual Studio #14833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psfinaki
approved these changes
Mar 1, 2023
Contributor
psfinaki
left a comment
psfinaki
left a comment
There was a problem hiding this comment.
Thanks for this. If you have any benchmarks at your hand - feel free to add to the PR.
KevinRansom
approved these changes
Mar 1, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #14826.
I reshuffled and simplified the old code of
FSharpNavigateToSearchServicequite a bit.Operators now show up correctly in search results.
The code previously used
Array.Parallelto collect search matches, so this was essentially not cancellable? This is replaced withAsync.Parallelwhich should behave better.Previously this service used
MemoryCachewith 10 sec lifetime. This may be controversial but I removed the MemoryCache in favor of simply caching everything in aConcurrentDictionary. This could take up maybe a few MBs in worst cases, but there should be a lot less GC and CPU activity on subsequent searches. Cache is now cleared on solution close.