Add GH action to manage servicing branch codeflow. #18267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ No release notes required |
Member
Author
|
@vzarytovskii ptal |
Member
Thanks Joey, I've moved out of the team recently, @0101, please review. Docs will also need changing, to change branches in this repo and not in Roslyn tools. |
arunchndr
approved these changes
Jan 24, 2025
vzarytovskii
approved these changes
Jan 25, 2025
Member
vzarytovskii
left a comment
vzarytovskii
left a comment
There was a problem hiding this comment.
Looks good. I'll leave it to the team to merge. @JoeRobich do you happen to know when will the old tool be disabled?
0101
approved these changes
Jan 27, 2025
Since there needs to be a separate config for each feature.
Member
Author
F# is the last team with any configuration in it. I will disable it asap! |
Member
Author
And it is disabled. |
JoeRobich
added a commit
to dotnet/roslyn-tools
that referenced
this pull request
Jan 27, 2025
F# moved to Arcade inter-merge GH action in dotnet/fsharp#18267
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Roslyn team is looking to retire their GH codeflow pipeline. This PR moves your configuration over to the Arcade inter branch merge approach. There are differences between the two system as the Arcade configuration does not support merging a branch into multiple upstreams. I have compensated for this by having multiple configurations and separate jobs for each.