make Internal.Utilities.Text.Lexing.Position a struct

[vasily-kirichenko]

Back porting fsharp/fsharp-compiler-docs#415

use a structs instead of a couple Tuples in LexFilter
make Internal.Utilities.Text.Lexing.Position a struct

[vasily-kirichenko]

It does not compile on my machine though:

------ Build started: Project: FSharp.Core, Configuration: Debug Any CPU ------
D:\git\visualfsharp\src\assemblyinfo\assemblyinfo.FSharp.Core.dll.fs(12,1): error FS1169: #if directive should be immediately followed by an identifier
D:\git\visualfsharp\src\assemblyinfo\assemblyinfo.FSharp.Core.dll.fs(14,1): error FS0010: #endif has no matching #if in definition
D:\git\visualfsharp\src\assemblyinfo\assemblyinfo.FSharp.Core.dll.fs(23,1): error FS0010: Incomplete structured construct at or before this point in implementation file
------ Build started: Project: FSharp.Compiler, Configuration: Debug Any CPU ------
D:\git\visualfsharp\src\fsharp\ExtensionTyping.fs(517,22): error FS0039: The type 'ITypeProvider2' is not defined
D:\git\visualfsharp\src\fsharp\ExtensionTyping.fs(518,21): error FS0072: Lookup on object of indeterminate type based on information prior to this program point. A type annotation may be needed prior to this program point to constrain the type of the object. This may allow the lookup to be resolved.
D:\git\visualfsharp\src\fsharp\ExtensionTyping.fs(533,22): error FS0039: The type 'ITypeProvider2' is not defined
D:\git\visualfsharp\src\fsharp\ExtensionTyping.fs(534,21): error FS0072: Lookup on object of indeterminate type based on information prior to this program point. A type annotation may be needed prior to this program point to constrain the type of the object. This may allow the lookup to be resolved.
D:\git\visualfsharp\src\fsharp\vs\ServiceUntypedParse.fs(582,55): error FS0039: The value, constructor, namespace or type 'item' is not defined
D:\git\visualfsharp\src\fsharp\vs\ServiceUntypedParse.fs(582,49): error FS0072: Lookup on object of indeterminate type based on information prior to this program point. A type annotation may be needed prior to this program point to constrain the type of the object. This may allow the lookup to be resolved.
D:\git\visualfsharp\src\fsharp\vs\ServiceUntypedParse.fs(583,96): error FS0039: The value, constructor, namespace or type 'item' is not defined
D:\git\visualfsharp\src\fsharp\vs\ServiceUntypedParse.fs(583,90): error FS0072: Lookup on object of indeterminate type based on information prior to this program point. A type annotation may be needed prior to this program point to constrain the type of the object. This may allow the lookup to be resolved.
D:\git\visualfsharp\src\fsharp\vs\ServiceDeclarations.fs(607,86): error FS0039: The value, constructor, namespace or type 'item' is not defined
D:\git\visualfsharp\src\fsharp\vs\ServiceDeclarations.fs(871,58): error FS0039: The value, constructor, namespace or type 'item' is not defined

It seems like VS 2015 use 3.1 compiler or the like.

[KevinRansom]

Committed, thank you for this contribution.

[rojepp]

What was the reason for not using the merge button again? ;)