Skip to content

Conversation

@GangWang01
Copy link
Member

Fix

#461

Solution

In the case that the response ends without final code 2xx/4xx/5xx, getting broken redirects includes last http code.

@YuliiaKovalova
Copy link
Member

YuliiaKovalova commented Apr 25, 2024

Could you please cover the case with .net 9 here and check other places where preview is missed?
https://github.com/GangWang01/install-scripts/blob/cc56933f989275e5dabe35441e224845ef9e7a44/tests/Install-Scripts.Test/GivenThatIWantToInstallDotnetFromAScript.cs#L40

The implementation is great, just want to fill the existing gaps in testing ;)

@YuliiaKovalova
Copy link
Member

thank you!

@YuliiaKovalova YuliiaKovalova merged commit 7db3da5 into dotnet:main Apr 26, 2024
bigdaddykane18 pushed a commit to bigdaddykane18/install-scripts that referenced this pull request Apr 22, 2025
…inal code 2xx/4xx/5xx (dotnet#464)

* Correct broken redirects in the case that the response ends without final code 2xx/4xx/5xx

* Add test cases for installing dotnet 9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants