Skip to content

Reopen a notebook does not mark it as modified #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 7, 2023
Merged

Reopen a notebook does not mark it as modified #2789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
656be8b
update only when different
colombod Mar 7, 2023
92f3d32
fix build
colombod Mar 7, 2023
14ceab5
feedback
colombod Mar 7, 2023
322e1a8
filter kernels that do not support submit code
colombod Mar 7, 2023
99e926c
notebooks
colombod Mar 7, 2023
afc82cf
rename argument
colombod Mar 7, 2023
79c3e47
notebooks
colombod Mar 7, 2023
4736e8f
notebooks
colombod Mar 7, 2023
37d70fd
reduce amount of sorting
colombod Mar 7, 2023
f9056a9
update test
colombod Mar 7, 2023
9244cec
check for update after cell run request
colombod Mar 7, 2023
6f890ab
notebook
colombod Mar 7, 2023
30561be
notebook
colombod Mar 7, 2023
25ac777
set up transient behaviour to avoid marking dib dirty
colombod Mar 7, 2023
622f5e5
Update src/polyglot-notebooks-vscode-common/src/notebookControllers.ts
colombod Mar 7, 2023
b7f8f65
rename meathod
colombod Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
123 changes: 118 additions & 5 deletions samples/notebooks/polyglot/Azure logs.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,14 @@
"cells": [
{
"cell_type": "markdown",
"metadata": {},
"metadata": {
"dotnet_interactive": {
"language": "powershell"
},
"polyglot_notebook": {
"kernelName": "powershell"
}
},
"source": [
"[this doc on github](https://github.com/dotnet/interactive/tree/main/samples/notebooks/polyglot)\n",
"\n"
Expand All @@ -14,6 +21,9 @@
"metadata": {
"dotnet_interactive": {
"language": "pwsh"
},
"vscode": {
"languageId": "polyglot-notebook"
}
},
"outputs": [],
Expand All @@ -27,6 +37,9 @@
"metadata": {
"dotnet_interactive": {
"language": "pwsh"
},
"vscode": {
"languageId": "polyglot-notebook"
}
},
"outputs": [],
Expand All @@ -40,6 +53,9 @@
"metadata": {
"dotnet_interactive": {
"language": "pwsh"
},
"vscode": {
"languageId": "polyglot-notebook"
}
},
"outputs": [],
Expand All @@ -53,6 +69,9 @@
"metadata": {
"dotnet_interactive": {
"language": "pwsh"
},
"vscode": {
"languageId": "polyglot-notebook"
}
},
"outputs": [],
Expand All @@ -66,6 +85,9 @@
"metadata": {
"dotnet_interactive": {
"language": "pwsh"
},
"vscode": {
"languageId": "polyglot-notebook"
}
},
"outputs": [],
Expand All @@ -79,6 +101,9 @@
"metadata": {
"dotnet_interactive": {
"language": "pwsh"
},
"vscode": {
"languageId": "polyglot-notebook"
}
},
"outputs": [],
Expand All @@ -94,6 +119,9 @@
"metadata": {
"dotnet_interactive": {
"language": "pwsh"
},
"vscode": {
"languageId": "polyglot-notebook"
}
},
"outputs": [],
Expand All @@ -120,6 +148,9 @@
"metadata": {
"dotnet_interactive": {
"language": "pwsh"
},
"vscode": {
"languageId": "polyglot-notebook"
}
},
"outputs": [],
Expand All @@ -140,18 +171,100 @@
],
"metadata": {
"kernelspec": {
"display_name": ".NET (PowerShell)",
"language": "PowerShell",
"name": ".net-powershell"
"display_name": ".NET (C#)",
"language": "C#",
"name": ".net-csharp"
},
"language_info": {
"file_extension": ".ps1",
"mimetype": "text/x-powershell",
"name": "PowerShell",
"pygments_lexer": "powershell",
"version": "7.0"
},
"polyglot_notebook": {
"kernelInfo": {
"defaultKernelName": "powershell",
"items": [
{
"aliases": [],
"languageName": null,
"name": ".NET"
},
{
"aliases": [
"C#",
"c#"
],
"languageName": "C#",
"name": "csharp"
},
{
"aliases": [
"F#",
"f#"
],
"languageName": "F#",
"name": "fsharp"
},
{
"aliases": [],
"languageName": "HTML",
"name": "html"
},
{
"aliases": [
"js"
],
"languageName": "JavaScript",
"name": "javascript"
},
{
"aliases": [],
"languageName": "KQL",
"name": "kql"
},
{
"aliases": [],
"languageName": "Mermaid",
"name": "mermaid"
},
{
"aliases": [],
"name": "powershell"
},
{
"aliases": [
"powershell"
],
"languageName": "PowerShell",
"name": "pwsh"
},
{
"aliases": [],
"languageName": "SQL",
"name": "sql"
},
{
"aliases": [],
"languageName": null,
"name": "value"
},
{
"aliases": [
"frontend"
],
"languageName": null,
"name": "vscode"
Copy link
Contributor

@jonsequitur jonsequitur Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the list?

Copy link
Member Author

@colombod colombod Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is one of the kernel present

Copy link
Member Author

@colombod colombod Mar 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filtering out kernels not implementing submitcode

},
{
"aliases": [],
"name": "webview"
}
]
}
}
},
"nbformat": 4,
"nbformat_minor": 4
}
}
2 changes: 1 addition & 1 deletion samples/notebooks/polyglot/COVID-19-fsharp.dib
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!meta

{"kernelInfo":{"defaultKernelName":"csharp","items":[{"name":"csharp","aliases":["c#","C#"],"languageName":"C#"},{"name":".NET","aliases":[]},{"name":"fsharp","aliases":["f#","F#"],"languageName":"F#"},{"name":"html","aliases":[],"languageName":"HTML"},{"name":"kql","aliases":[],"languageName":"KQL"},{"name":"mermaid","aliases":[],"languageName":"Mermaid"},{"name":"pwsh","aliases":["powershell"],"languageName":"PowerShell"},{"name":"sql","aliases":[],"languageName":"SQL"},{"name":"value","aliases":[]},{"name":"vscode","languageName":null,"aliases":["frontend"]}]}}
{"kernelInfo":{"defaultKernelName":"csharp","items":[{"aliases":["F#","f#"],"languageName":"F#","name":"fsharp"},{"aliases":[],"languageName":"HTML","name":"html"},{"aliases":[],"languageName":"Mermaid","name":"mermaid"},{"aliases":["powershell"],"languageName":"PowerShell","name":"pwsh"},{"aliases":[],"name":"value"}]}}

#!markdown

Expand Down
18 changes: 4 additions & 14 deletions samples/notebooks/polyglot/COVID-19.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,20 +386,16 @@
"items": [
{
"aliases": [
"c#",
"C#"
"C#",
"c#"
],
"languageName": "C#",
"name": "csharp"
},
{
"aliases": [],
"name": ".NET"
},
{
"aliases": [
"f#",
"F#"
"F#",
"f#"
],
"languageName": "F#",
"name": "fsharp"
Expand Down Expand Up @@ -434,12 +430,6 @@
{
"aliases": [],
"name": "value"
},
{
"aliases": [
"frontend"
],
"name": "vscode"
}
]
}
Expand Down
Loading