-
Notifications
You must be signed in to change notification settings - Fork 63
[generator] FixupMethodOverrides()
checks properties
#1366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #1313 Fixes: dotnet/android#10509 In .NET 10 RC 1, `View.Foreground` is defined in C# as: [SupportedOSPlatform("android23.0")] public virtual Drawable? Foreground { get; set; } But `FrameLayout.Foreground` is defined as: [UnsupportedOSPlatform("android23.0")] public override Drawable? Foreground { get; set; } I think this is the exact same bug that was addressed in #1313 for methods, but we still have the issue for properties. I was able to duplicate the test and make a `getThing()` and `setThing()` methods in Java to see the issue. I updated the `FixupMethodOverrides()` to iterate over properties and do the same fixup for property getters and setters.
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Sep 22, 2025
jonathanpeppers
added a commit
that referenced
this pull request
Sep 22, 2025
Context: #1313 Context: dotnet/android#10509 Reverts: * 28d6905 * 1cfb4f4 To reduce the chance of breakage in .NET 10, going to revert this feature on `release/10.0.1xx`. The changes will be left in `main` along with the fix: * #1366
grendello
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1313
Fixes: dotnet/android#10509
In .NET 10 RC 1,
View.Foreground
is defined in C# as:But
FrameLayout.Foreground
is defined as:I think this is the exact same bug that was addressed in #1313 for methods, but we still have the issue for properties. I was able to duplicate the test and make a
getThing()
andsetThing()
methods in Java to see the issue.I updated the
FixupMethodOverrides()
to iterate over properties and do the same fixup for property getters and setters.