Skip to content

Evaluation result classes shouldn't be nested under the Evaluator classes #1280

@eerhardt

Description

@eerhardt

When using our evaluation API:

BinaryClassificationContext binClassificationCtx = new BinaryClassificationContext(env);
BinaryClassifierEvaluator.CalibratedResult metrics = binClassificationCtx.Evaluate(predictions, "Label");

It is quite odd for the metrics object to be a nested class in the BinaryClassifierEvaluator. I didn't even use the BinaryClassifierEvaluator class at all, why am I dealing with a nested class inside of it?

I think these result classes should be moved to no longer be nested classes. Instead we should just have a BinaryClassifierEvaluationResult class.

/cc @Zruty0 @TomFinley @KrzysztofCwalina @terrajobst

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgood first issueGood for newcomersup-for-grabsA good issue to fix if you are trying to contribute to the project

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions