New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RffWorkout test is not stable and randomy fails during the build. #1825

Closed
wschin opened this Issue Dec 5, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@wschin
Member

wschin commented Dec 5, 2018

As title. I failed multiple times for some unknown reasons. It needs to be improved for a more smooth merging process.

@singlis singlis added the bug label Dec 5, 2018

@singlis singlis self-assigned this Dec 5, 2018

@singlis

This comment has been minimized.

Member

singlis commented Dec 5, 2018

Thanks @wschin, I will take a look.

@singlis

This comment has been minimized.

Member

singlis commented Dec 5, 2018

@wschin Is there a specific platform this is failing on?

@singlis

This comment has been minimized.

Member

singlis commented Dec 5, 2018

@Ivanidzo4ka

This comment has been minimized.

Member

Ivanidzo4ka commented Dec 5, 2018

I download RffStatic test output file and it looks like we have error in 7th digit or so. So easy solution is to just change precision.
For RffWorkout, it's kinda mystery. It fails in Done method which shouldn't happen. Done checks certain variable which we set to true during initialization, and never changed in test.

@Zruty0

This comment has been minimized.

Member

Zruty0 commented Dec 5, 2018

I believe that we actually set the 'passed' field during CheckSameSchema and CheckSameValues, which is consistent with the assumption that RFF is not deterministic.

@singlis

This comment has been minimized.

Member

singlis commented Dec 5, 2018

Please see this PR:
#1829

It changes the precision to 1e-3 from 1e-6.

@singlis

This comment has been minimized.

Member

singlis commented Dec 6, 2018

@Zruty0 - I will check the passed field as well.

@singlis

This comment has been minimized.

Member

singlis commented Dec 7, 2018

From the thread on #1829, the intermittent failures were due to change #1657, which was reverted in #1838. I have also not seen it repro in the build since the revert, so marking this as closed.

@singlis singlis closed this Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment