New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The projects containing the static extensions are generally not part of any NuGet. #2094

Open
sfilipi opened this Issue Jan 9, 2019 · 3 comments

Comments

Projects
4 participants
@sfilipi
Copy link
Member

sfilipi commented Jan 9, 2019

I believe the projects with the name pattern Microsoft.ML.*.StaticPipe were created setting apart the static extensions so they can be on a separate nuget package.

Most of them are currently part of no package. There exists a main package for the main project containing the static pipe: Microsoft.ML.StaticPipe.

@TomFinley, @glebuk @shauheen Should those projects be part of that package, or separate package?

cc @abgoswam, @eerhardt

Note: this issue can be closed when all the projects containing static extensions are part of NuGet packages, depending on the resolution of the question above.

@shauheen

This comment has been minimized.

Copy link
Member

shauheen commented Jan 9, 2019

#2076 was done to address part of this issue. That NuGet should contain everything Static API.

@abgoswam

This comment has been minimized.

Copy link
Member

abgoswam commented Jan 9, 2019

Thanks Senja for the issue.

As part of #1914, we created separate 5 assemblies for static extensions. These assemblies are named corresponding to nuget packages (with the Microsoft.ML prefix)

  1. Microsoft.ML.StaticPipe
  2. Microsoft.ML.LightGBM.StaticPipe
  3. Microsoft.ML.TensorFlow.StaticPipe
  4. Microsoft.ML.OnnxTransform.StaticPipe
  5. Microsoft.ML.HalLearners.StaticPipe

TODOs

A. There should be two more assemblies that we should add to the list:

  • Microsoft.ML.Recommender.StaticPipe (based on #2077)
  • Microsoft.ML.TimeSeries.StaticPipe (based on #1656)

B. Nuget story for the Static API ?

  • Should we add separate nugets, one each for the static assemblies mentioned above ? #2072 introduces a nuget Microsoft.ML.StaticPipe
    Or
  • Should we have only the Microsoft.ML.StaticPipe nuget , and have that nuget contain everything related to Static APIs ?
@TomFinley

This comment has been minimized.

Copy link
Contributor

TomFinley commented Jan 9, 2019

I think we should add these static pipe nugets as part of v0.10, but for v0.9 you are correct we deliberately only shipped the "main" one as part of a nuget.

The ideal situation is separate nugets, I think. It would be nice if the "core" nuget package references only a few small nugets. Anything referencing a larger nuget, should be in its own nuget and not bundled with that. That in mind @abgoswam's project should provisionally be considered to reflect the desired nuget story.

  1. Microsoft.ML.LightGBM.StaticPipe
  2. Microsoft.ML.TensorFlow.StaticPipe
  3. Microsoft.ML.OnnxTransform.StaticPipe
  4. Microsoft.ML.HalLearners.StaticPipe

These should each have separate nugets, if the things they depend on have separate nugets, which they all do. I considered these unessential to ship as part of v0.9 though considering the limited timeframe.

@shauheen shauheen added this to To Do in v0.10 Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment