Fix bug in ApplyAt in VBufferUtils #1757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
approved these changes
Nov 28, 2018
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Looks great. Thanks for investigating and fixing this mistake.
|
|
||
| namespace Microsoft.ML.Core.Tests.UnitTests | ||
| { | ||
| public sealed class TestVBuffer |
Member
There was a problem hiding this comment.
(Nit) I would name this class and file “TestVBufferUtils” instead, because that is what it is testing.
| var buffer = new VBuffer<float>(10, 3, new[] { 0.5f, 1.2f, -3.8f }, new[] { 1, 5, 8 }); | ||
| VBufferUtils.ApplyAt(ref buffer, 6, (int slot, ref float value) => { value = value + 1; }); | ||
| Assert.Equal(4, buffer.GetValues().Length); | ||
| Assert.Equal(1, buffer.GetValues()[2]); |
Member
There was a problem hiding this comment.
Can you verify all the values and indices are correct?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create the editor, we lose the old values that were in the VBuffer in case it has to be resized.
Fixes #1756 .