Add fixes to prevent potential build failures due to redist copying #1775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
reviewed
Nov 29, 2018
| DependsOnTargets="DownloadDnnModelFiles"> | ||
| <Message Importance="High" Text="Copying external model files... @(ModelFileCopy->'%(TargetPath)')" /> | ||
| <Copy SourceFiles="@(ModelFileCopy)" | ||
| Condition="'$(SkipRIDAgnosticAssets)' == ''" |
Member
There was a problem hiding this comment.
Condition checking in MSBuild is a little different. Typically "boolean" properties will have 3 values: empty, true, and false. So generally, you pick empty (the default) to be considered the same as either 'true' or 'false'. In our case here, the default for SkipRIDAgnosticAssets should be false. So instead it is best to write this condition as:
Condition="'$(SkipRIDAgnosticAssets)' != 'true'"
That way someone can explicitly set /p:SkipRIDAgnosticAssets=false, and it still works correctly. #Resolved
eerhardt
approved these changes
Nov 29, 2018
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Looks good - with just one minor condition-writing suggestion.
Member
|
Let's get this in, since 2 more builds just failed because of this. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new build script flag that allows specifying that certain RID agnostic files inside redist should not be built/executed. This is used to prevent the DNNImageFeaturizer models from being copied on each leg causing possible build failures. Instead, the copying only happens on Windows x64. Fixes #1775