Delete IColumn #1801
Merged
Delete IColumn #1801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stop using IColumn in predicted label scorers. * Stop using IColumn in static schema shape analysis. * Stop using IColumn in linear model statistics creation.
* Stop using IColumn in FastTree statistics creation. * Stop using IColumn in benchmarking. * Stop using IColumn in many tests. * Add minor conveniences to metadata builder. * Allow metadata builder to have metadata of metadata. * Add appropriate validation in certain places. * Put warnings on an inappropriate method dealing with Batch that should not exist.
TomFinley
requested review from
Ivanidzo4ka,
Zruty0,
artidoro,
eerhardt,
sfilipi,
wschin and
yaeldekel
sfilipi
reviewed
Dec 2, 2018
wschin
reviewed
Dec 3, 2018
| /// <param name="type">The metadata type.</param> | ||
| /// <param name="getter">The getter delegate.</param> | ||
| public void Add<TValue>(string name, ColumnType type, ValueGetter<TValue> getter) | ||
| /// <param name="metadata">Metadata of the input column. Note that metadata on a metadata column is somewhat rare |
Member
There was a problem hiding this comment.
What does input column mean here? Is it a metadata column (specified by name, type, getter) or a column which metadata will be attached to? Maybe change input column to metadata column added?
Contributor
Author
There was a problem hiding this comment.
Ah. I'll think about this and handle in next PR after this.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1755.
At least initially staged as three commits, where we change some places, change the more difficult and rote places like tests and whatnot, then remove everything.